fix buggy refresh (patch) #950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaaax
force-pushed
the
948-bug-rechargement-de-la-page-sur-le-mauvais-onglet-transverse
branch
from
79dd08c to
4e531ae
Compare
* Each tab has its slug as a route parameter * Default redirect to first tab * History management between tabs * Better scroll behavior: * generally try to display tabs at the top of the screen when navigating between tabs * remember saved positions (mimics native browser behavior) * Dynamic scroll margin to always scroll to the proper position * Add a "useResizeObserver" (taken from vueuse project)
yaaax
force-pushed
the
948-bug-rechargement-de-la-page-sur-le-mauvais-onglet-transverse
branch
from
4b9dac5 to
175258f
Compare
…is-onglet-transverse
yaaax
force-pushed
the
948-bug-rechargement-de-la-page-sur-le-mauvais-onglet-transverse
branch
from
175258f to
3d8f1bb
Compare
LayoutIcon is used on tab "Éléments transverses"
benoitdequick
changed the title
yaaax
force-pushed
the
948-bug-rechargement-de-la-page-sur-le-mauvais-onglet-transverse
branch
from
456ee58 to
ea31ccd
Compare
yaaax
force-pushed
the
948-bug-rechargement-de-la-page-sur-le-mauvais-onglet-transverse
branch
from
ea31ccd to
f7f5e07
Compare
benoitdequick
requested review from
bellangerq and
hissalht
and removed request for
bellangerq
* it simplifies the architecture as selecting a new tab always changes the route * + Add some enums and use them to avoid using slugify to much
yaaax
force-pushed
the
948-bug-rechargement-de-la-page-sur-le-mauvais-onglet-transverse
branch
from
f7f5e07 to
dd5417b
Compare
bellangerq
reviewed
Mar 5, 2025
| component: AuditGenerationPageCriteria, | ||
| componentParams: { | ||
| page: transversePage, | ||
| auditUniqueId: "uniqueId" |
There was a problem hiding this comment.
Utiliser la prop : props.uniqueId
bellangerq
reviewed
Mar 5, 2025
| component: AuditGenerationPageCriteria, | ||
| componentParams: { | ||
| page: p, | ||
| auditUniqueId: "uniqueId" |
There was a problem hiding this comment.
Utiliser la prop : props.uniqueId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #839
closes #934
closes #949