Catch URLError in tests when trying to download local attr values #407

SolarDrew · 2024-06-26T11:10:58Z

Closes #381

codspeed-hq · 2024-06-26T11:21:33Z

CodSpeed Performance Report

_{Comparing SolarDrew:attr-fix (c2d1c68) with main (16b61e1)}

✅ 3 untouched benchmarks

dkist/net/attrs_values.py

dkist/net/attrs_values.py

SolarDrew added 2 commits June 26, 2024 12:08

Catch URLError in tests when trying to download local attr values

20bf6b1

Closes DKISTDC#381

Add changelog

1e8be03

SolarDrew assigned SolarDrew and Cadair and unassigned SolarDrew Jun 26, 2024

Cadair reviewed Jun 26, 2024

View reviewed changes

dkist/net/attrs_values.py Outdated Show resolved Hide resolved

SolarDrew and others added 3 commits July 8, 2024 15:59

Catch URLError in tests when trying to download local attr values

f1948e5

Closes DKISTDC#381

Add changelog

9ea7f49

Split out download and save to reduce delete

f9e6f62

Cadair force-pushed the attr-fix branch from 9c12d56 to f9e6f62 Compare July 8, 2024 15:00

SolarDrew commented Jul 8, 2024

View reviewed changes

dkist/net/attrs_values.py Show resolved Hide resolved

SolarDrew added 4 commits July 11, 2024 15:20

Merge branch 'attr-fix' of github.com:SolarDrew/dkist into attr-fix

d40f243

Pedantry

1c11a24

Seems like an easy fix but I think this should be correct

94e08a4

An incomplete pedantry is the hobgoblin of little tests

c2d1c68

Cadair approved these changes Jul 11, 2024

View reviewed changes

Cadair merged commit b9cf9cc into DKISTDC:main Jul 11, 2024
19 of 20 checks passed