Made cloudwatch resources optional #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzrocha
reviewed
Aug 22, 2023
| @@ -1,4 +1,5 @@ | |||
| resource "aws_cloudwatch_log_group" "ecs_events" { | |||
| count = var.cloudwatch_logs_create ? 1 : 0 | |||
There was a problem hiding this comment.
Do we need to disable the creation of a new CW log group or the aws_cloudwatch_log_resource_policy only?
| @@ -8,6 +9,7 @@ resource "aws_cloudwatch_log_group" "ecs_events" { | |||
|
|
|||
|
|
|||
| resource "aws_cloudwatch_event_rule" "ecs_events" { | |||
| count = var.cloudwatch_logs_create ? 1 : 0 | |||
| name = "capture-ecs-events-${var.cluster_name}-${var.name}" | |||
There was a problem hiding this comment.
What if I want to use an existing aws_cloudwatch_log_resource_policy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to setup ECS service it is creating a "aws_cloudwatch_log_resource_policy" which has a hard limit "Up to 10 CloudWatch Logs resource policies per Region per account. This quota can't be changed."
Created variable to optionally not create cloudwatch log resources.
Relevant issue:
#40
Types of changes
What types of changes does your code introduce to <repo_name>?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.