Code

GTiff Reading and Writing#5618

Code

Open

acpaquette wants to merge 122 commits intoDOI-USGS:devDOI-USGS/ISIS3:devfrom acpaquette:gdal_ioacpaquette/ISIS3:gdal_ioCopy head branch name to clipboard

+3,385-467

Commits

Commits on Dec 10, 2024

• replaced custom min/max with std::max/std::min

  

  Kelvinrr

  authored and

  acpaquette

  committed
  e2e946a

  Copy full SHA for e2e946a

• left a gdal reference in

  

  Kelvinrr

  authored and

  acpaquette

  committed
  4fbdb2e

  Copy full SHA for 4fbdb2e

• Initial changes for a GdalIoHandler and creating an external DN cube

  acpaquette

  committed
  55b6a6d

  Copy full SHA for 55b6a6d

• added write + tests

  

  Kelvinrr

  authored and

  acpaquette

  committed
  7faadbe

  Copy full SHA for 7faadbe

• Initial move away two flags on the cube to using the LabelAttachment to define label state

  acpaquette

  committed
  71fadbf

  Copy full SHA for 71fadbf

• Addressed PR feedback

  acpaquette

  committed
  4582ff2

  Copy full SHA for 4582ff2

• Added external gdal support to cube

  acpaquette

  committed
  6b45531

  Copy full SHA for 6b45531

• Changed Tiff type to GTiff

  acpaquette

  committed
  c026c13

  Copy full SHA for c026c13

• Renamed imageIoHandler to ImageIoHandler

  acpaquette

  committed
  b8e14af

  Copy full SHA for b8e14af

• Added pixeltype to gdaliohandler constructor

  acpaquette

  committed
  0d41bfd

  Copy full SHA for 0d41bfd

• Added gdal pixel type translation and missing special pixels for various ISIS pixel types

  acpaquette

  committed
  a6d157a

  Copy full SHA for a6d157a

• Small fixes to get things working

  acpaquette

  committed
  fc8e4e8

  Copy full SHA for fc8e4e8

• Removed prints and added -1s back to read and write

  acpaquette

  committed
  04dd5f6

  Copy full SHA for 04dd5f6

• Changed gdal reads to use the raw buffer and correctly apply the ISIS pixel type

  acpaquette

  committed
  0da457b

  Copy full SHA for 0da457b

• Added initial pixel conversions and tests for writing

  acpaquette

  committed
  d124b0f

  Copy full SHA for d124b0f

• Final tests for pixel type reading and writing

  acpaquette

  committed
  0f75950

  Copy full SHA for 0f75950

• Added tiff fixtures

  acpaquette

  committed
  09b5c8d

  Copy full SHA for 09b5c8d

• Transfered pixel type to gdal handler in cube

  acpaquette

  committed
  9e080b6

  Copy full SHA for 9e080b6

• Silenced unsued return warning

  acpaquette

  committed
  61c4217

  Copy full SHA for 61c4217

• Reused file handler in TiffFixture

  acpaquette

  committed
  0bb5d8c

  Copy full SHA for 0bb5d8c

• added virtual band checks

  

  Kelvinrr

  authored and

  acpaquette

  committed
  5f923ac

  Copy full SHA for 5f923ac

• Added default compression for tiffs

  acpaquette

  committed
  604c808

  Copy full SHA for 604c808

• Removed max again

  acpaquette

  committed
  5ce9a20

  Copy full SHA for 5ce9a20

• Opened up the environment to get a work env

  acpaquette

  committed
  3e4adf9

  Copy full SHA for 3e4adf9

• Fixed boolean comparisons against enum

  acpaquette

  committed
  24029ea

  Copy full SHA for 24029ea

• Initial stab at fixing the buffer copy

  acpaquette

  committed
  ea06217

  Copy full SHA for ea06217

• Adds msk file writting for tiffs

  acpaquette

  committed
  cb2abb3

  Copy full SHA for cb2abb3

• Added boundary check for buffers

  acpaquette

  committed
  3a92ae0

  Copy full SHA for 3a92ae0

• Added fixture function to write a M x N x O tiff

  acpaquette

  committed
  3a610fb

  Copy full SHA for 3a610fb

• Reverted commented out Index access function Exceptions

  acpaquette

  committed
  4467612

  Copy full SHA for 4467612

• Default tiff DNs to the noDataValue

  acpaquette

  committed
  9963208

  Copy full SHA for 9963208

• Cleaned up buffer boundary handling for reads and writes

  acpaquette

  committed
  5c247b3

  Copy full SHA for 5c247b3

• Added gdal io tests for reading outside of the image

  acpaquette

  committed
  6820edc

  Copy full SHA for 6820edc

• Updated shadow functional tests

  acpaquette

  committed
  656477f

  Copy full SHA for 656477f

• Properly handled pointers for mac and linux

  acpaquette

  committed
  56d0150

  Copy full SHA for 56d0150

• Removed commented out line

  acpaquette

  committed
  14081bb

  Copy full SHA for 14081bb

• Addressed OS dependent shadow failures

  acpaquette

  committed
  ea92118

  Copy full SHA for ea92118

Commits on Dec 11, 2024

• Removed read contraints on ecubes

  acpaquette

  committed
  aa82731

  Copy full SHA for aa82731

• Moved CubeIoHandler getters into public space

  acpaquette

  committed
  0ed2884

  Copy full SHA for 0ed2884

Commits on Dec 12, 2024

• Moved CubeIoHandler getters into public space

  acpaquette

  committed
  84afea7

  Copy full SHA for 84afea7

• Made getDataFile protected

  acpaquette

  committed
  abe4f1a

  Copy full SHA for abe4f1a

• Made realDataFileName public on cube

  acpaquette

  committed
  bfd4cd0

  Copy full SHA for bfd4cd0

• Added new cube tests as gtests

  acpaquette

  committed
  21185c1

  Copy full SHA for 21185c1

• Added CubeBsqHandlerTests

  acpaquette

  committed
  f644dc7

  Copy full SHA for f644dc7

• Removed old Cube unittests

  acpaquette

  committed
  bb5177f

  Copy full SHA for bb5177f

• Removed cube truth

  acpaquette

  committed
  a8b3204

  Copy full SHA for a8b3204

• Handled gdal warnings in GdalIoHandler and its tests

  acpaquette

  committed
  cf30bb9

  Copy full SHA for cf30bb9

• Merge branch 'new_cube_tests' into gdal_io

  acpaquette

  committed
  8788d09

  Copy full SHA for 8788d09

• Fixed compiler warnings in TiffFixture

  acpaquette

  committed
  27c1b9c

  Copy full SHA for 27c1b9c

• Reverted data cube truncation

  acpaquette

  committed
  6a84388

  Copy full SHA for 6a84388

Commits on Dec 13, 2024

• replaced custom min/max with std::max/std::min

  

  Kelvinrr

  authored and

  acpaquette

  committed
  e69b3a1

  Copy full SHA for e69b3a1

• left a gdal reference in

  

  Kelvinrr

  authored and

  acpaquette

  committed
  c4aa3e1

  Copy full SHA for c4aa3e1

• Initial changes for a GdalIoHandler and creating an external DN cube

  acpaquette

  committed
  4aaa9ca

  Copy full SHA for 4aaa9ca

• added write + tests

  

  Kelvinrr

  authored and

  acpaquette

  committed
  5f3790e

  Copy full SHA for 5f3790e

• Initial move away two flags on the cube to using the LabelAttachment to define label state

  acpaquette

  committed
  0e92d08

  Copy full SHA for 0e92d08

• Addressed PR feedback

  acpaquette

  committed
  53299fc

  Copy full SHA for 53299fc

• Added external gdal support to cube

  acpaquette

  committed
  1c9fdf7

  Copy full SHA for 1c9fdf7

• Changed Tiff type to GTiff

  acpaquette

  committed
  33fd96f

  Copy full SHA for 33fd96f

• Renamed imageIoHandler to ImageIoHandler

  acpaquette

  committed
  fd40102

  Copy full SHA for fd40102

• Added pixeltype to gdaliohandler constructor

  acpaquette

  committed
  1a2136c

  Copy full SHA for 1a2136c

• Added gdal pixel type translation and missing special pixels for various ISIS pixel types

  acpaquette

  committed
  ba75d83

  Copy full SHA for ba75d83

• Small fixes to get things working

  acpaquette

  committed
  f4e9b13

  Copy full SHA for f4e9b13

• Removed prints and added -1s back to read and write

  acpaquette

  committed
  5efaa46

  Copy full SHA for 5efaa46

• Changed gdal reads to use the raw buffer and correctly apply the ISIS pixel type

  acpaquette

  committed
  603288f

  Copy full SHA for 603288f

• Added initial pixel conversions and tests for writing

  acpaquette

  committed
  5a2e460

  Copy full SHA for 5a2e460

• Final tests for pixel type reading and writing

  acpaquette

  committed
  aa3ce42

  Copy full SHA for aa3ce42

• Added tiff fixtures

  acpaquette

  committed
  4667f7f

  Copy full SHA for 4667f7f

• Transfered pixel type to gdal handler in cube

  acpaquette

  committed
  fe167db

  Copy full SHA for fe167db

• Silenced unsued return warning

  acpaquette

  committed
  efef488

  Copy full SHA for efef488

• Reused file handler in TiffFixture

  acpaquette

  committed
  f90714c

  Copy full SHA for f90714c

• added virtual band checks

  

  Kelvinrr

  authored and

  acpaquette

  committed
  171fbe7

  Copy full SHA for 171fbe7

• Added default compression for tiffs

  acpaquette

  committed
  9b02c24

  Copy full SHA for 9b02c24

• Removed max again

  acpaquette

  committed
  dbdd089

  Copy full SHA for dbdd089

• Opened up the environment to get a work env

  acpaquette

  committed
  54fcfb9

  Copy full SHA for 54fcfb9

• Fixed boolean comparisons against enum

  acpaquette

  committed
  f491c63

  Copy full SHA for f491c63

• Initial stab at fixing the buffer copy

  acpaquette

  committed
  1c99e94

  Copy full SHA for 1c99e94

• Adds msk file writting for tiffs

  acpaquette

  committed
  6220841

  Copy full SHA for 6220841

• Added boundary check for buffers

  acpaquette

  committed
  49e2853

  Copy full SHA for 49e2853

• Added fixture function to write a M x N x O tiff

  acpaquette

  committed
  7c4a839

  Copy full SHA for 7c4a839

• Reverted commented out Index access function Exceptions

  acpaquette

  committed
  063c211

  Copy full SHA for 063c211

• Default tiff DNs to the noDataValue

  acpaquette

  committed
  f4da201

  Copy full SHA for f4da201

• Cleaned up buffer boundary handling for reads and writes

  acpaquette

  committed
  8ef05af

  Copy full SHA for 8ef05af

• Added gdal io tests for reading outside of the image

  acpaquette

  committed
  fbb5535

  Copy full SHA for fbb5535

• Updated shadow functional tests

  acpaquette

  committed
  619d24a

  Copy full SHA for 619d24a

• Properly handled pointers for mac and linux

  acpaquette

  committed
  2b99b7b

  Copy full SHA for 2b99b7b

• Removed commented out line

  acpaquette

  committed
  bebe17f

  Copy full SHA for bebe17f

• Addressed OS dependent shadow failures

  acpaquette

  committed
  e030f8b

  Copy full SHA for e030f8b

• Removed read contraints on ecubes

  acpaquette

  committed
  258cba0

  Copy full SHA for 258cba0

• Handled gdal warnings in GdalIoHandler and its tests

  acpaquette

  committed
  8cced48

  Copy full SHA for 8cced48

• Fixed compiler warnings in TiffFixture

  acpaquette

  committed
  57d7add

  Copy full SHA for 57d7add

• Reverted data cube truncation

  acpaquette

  committed
  a6bbff3

  Copy full SHA for a6bbff3

• gdal json pvl parsing

  

  Kelvinrr

  authored and

  acpaquette

  committed
  9d5ddc9

  Copy full SHA for 9d5ddc9

• Update Pvl.cpp

  

  Kelvinrr

  authored and

  acpaquette

  committed
  a73d3d9

  Copy full SHA for a73d3d9

• Fixed gdal json to pvl parsing

  acpaquette

  committed
  29b864d

  Copy full SHA for 29b864d

• Updated cube tests with tiff read/write changes

  acpaquette

  committed
  8af2fb0

  Copy full SHA for 8af2fb0

Commits on Dec 16, 2024

• Moved Tiff creation into a function on Cube and made Tiff Cube metadata read an explicit constructor

  acpaquette

  committed
  e473cfd

  Copy full SHA for e473cfd

• Added PVL to Json export for GDAL metadata

  

  Kelvinrr

  authored and

  acpaquette

  committed
  1621834

  Copy full SHA for 1621834

Commits on Dec 30, 2024

• Fixed PVLKeyword toJson writing arrays

  acpaquette

  committed
  6c4fa34

  Copy full SHA for 6c4fa34

• Added string conversion for GTiff

  acpaquette

  committed
  5d5fc68

  Copy full SHA for 5d5fc68

• Extracted PVL read json lambda into static function

  acpaquette

  committed
  56aae0b

  Copy full SHA for 56aae0b

• Enforced Cube carry/manage GdalDataset object and made GdalIoHandler and Blob use it

  acpaquette

  committed
  8236bbe

  Copy full SHA for 8236bbe

• Fixed tiff fixtures alpha bands

  acpaquette

  committed
  ec3945f

  Copy full SHA for ec3945f

Commits on Jan 6, 2025

• Seperated ISD spice contructor and init function from default init function

  acpaquette

  committed
  862ae33

  Copy full SHA for 862ae33

• Fixed blob reading and writing from hex

  acpaquette

  committed
  8e12a87

  Copy full SHA for 8e12a87

• Fixed error message when reading a gdal blob

  acpaquette

  committed
  fcc569d

  Copy full SHA for fcc569d

• Fixed setting dataset ownership correctly on file constructor

  acpaquette

  committed
  66d68b8

  Copy full SHA for 66d68b8

• Fixed closing the dataset if we don't find the USGS metadata

  acpaquette

  committed
  ad30e77

  Copy full SHA for ad30e77

• Fixed cube test expected label size

  acpaquette

  committed
  cdc4fa2

  Copy full SHA for cdc4fa2

• Changed cube blob reading apps to access the blobs via the cube

  acpaquette

  committed
  3d1004d

  Copy full SHA for 3d1004d

• Merge branch 'temp_gdal_pvl' into gdal_io

  acpaquette

  committed
  e785e0e

  Copy full SHA for e785e0e

Commits on Jan 7, 2025

• Small fixes

  acpaquette

  committed
  c0885ba

  Copy full SHA for c0885ba

• Fixed issue with cam2map requesting buffers completely outside of the tiff

  acpaquette

  committed
  d46d1f5

  Copy full SHA for d46d1f5

Commits on Jan 10, 2025

• Applied cube label reading to catlab

  acpaquette

  committed
  dab8493

  Copy full SHA for dab8493

• Added blob read exception for GdalRead

  acpaquette

  committed
  cc55b31

  Copy full SHA for cc55b31

• Exposed IException vector length

  acpaquette

  committed
  1c948ed

  Copy full SHA for 1c948ed

• Handled GDALs nodatavalue

  acpaquette

  committed
  c5ab602

  Copy full SHA for c5ab602

• Moved GDAL pvl label construction into the Cube

  acpaquette

  committed
  a5d0237

  Copy full SHA for a5d0237

• Commented out mask creation

  acpaquette

  committed
  7f906ec

  Copy full SHA for 7f906ec

• Forced label reading to come from the cube in ctxcal

  acpaquette

  committed
  84506aa

  Copy full SHA for 84506aa

• Fixed data ownership when reading metadata from GTiff

  acpaquette

  committed
  cdcccc3

  Copy full SHA for cdcccc3

Commits on Jan 17, 2025

• Finalized mapping group generation from spatial reference

  acpaquette

  committed
  243e0a0

  Copy full SHA for 243e0a0

• Fix reading URLs in qview and blob reading

  acpaquette

  committed
  3594d90

  Copy full SHA for 3594d90