Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle missing page image case for export_to_html #166

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Conversation

kmyusk
Copy link
Contributor

@kmyusk kmyusk commented Feb 18, 2025

Fixes #165

@kmyusk kmyusk requested a review from cau-git February 18, 2025 12:12
Copy link

mergify bot commented Feb 18, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@kmyusk kmyusk requested a review from dolfim-ibm February 18, 2025 12:13
@kmyusk
Copy link
Contributor Author

kmyusk commented Feb 19, 2025

CI is failing on a file I did not touch FAILED test/test_docling_doc.py::test_formula_mathml - assert '<!DOCTYPE ht...pre>\n</html>' == '<!DOCTYPE ht...div>\n</html>'

Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kmyusk kmyusk merged commit 4708f93 into main Feb 25, 2025
8 checks passed
@kmyusk kmyusk deleted the fix/165 branch February 25, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export_to_html fails if there is a formula with empty text and no image of the formula
3 participants