fix: Fix the modalities for DPBench, OmniDocBench, DLNv1. Switch to new settings in SmolDocling API. Improve the documentation. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikos Livathinos <[email protected]>
…lean up code. Signed-off-by: Nikos Livathinos <[email protected]>
…s and place links in Readme. Signed-off-by: Nikos Livathinos <[email protected]>
… to allow flash-attn Signed-off-by: Nikos Livathinos <[email protected]>
…broken links in the documentation. Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
…taset() Signed-off-by: Nikos Livathinos <[email protected]>
nikos-livathinos
force-pushed
the
nli/docs_flash_attn
branch
from
868d6af to
72bd897
Compare
Signed-off-by: Nikos Livathinos <[email protected]>
…chmark Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
nikos-livathinos
force-pushed
the
nli/docs_flash_attn
branch
from
f1ae716 to
23bedf7
Compare
kmyusk
pushed a commit
that referenced
this pull request
Feb 26, 2025
…ew settings in SmolDocling API. Improve the documentation. (#37) * chore: Change the pinning of docling Signed-off-by: Nikos Livathinos <[email protected]> * fix: Fix the modalities supported for DPBench, OmniDocBench, DLNv1. Clean up code. Signed-off-by: Nikos Livathinos <[email protected]> * docs: Update documentation to have all benchmarks in separate md files and place links in Readme. Signed-off-by: Nikos Livathinos <[email protected]> * fix: Change the initialization of the create_smol_docling_converter() to allow flash-attn Signed-off-by: Nikos Livathinos <[email protected]> * docs: List benchmarks in the main readme with short description. Fix broken links in the documentation. Signed-off-by: Nikos Livathinos <[email protected]> * docs: Fix broken link in Readme. Signed-off-by: Nikos Livathinos <[email protected]> * chore: Update lock file Signed-off-by: Nikos Livathinos <[email protected]> * fix: Add debug code to dump the predicted text in create_dlnv1_e2e_dataset() Signed-off-by: Nikos Livathinos <[email protected]> * chore: Update toml to pin docling with branch and extras Signed-off-by: Nikos Livathinos <[email protected]> * fix: Disable the generation of VLM text debugging files for DLNv1 benchmark Signed-off-by: Nikos Livathinos <[email protected]> * chore: Update toml to docling v2.25.0 with vln extra Signed-off-by: Nikos Livathinos <[email protected]> --------- Signed-off-by: Nikos Livathinos <[email protected]>
kmyusk
pushed a commit
that referenced
this pull request
Feb 26, 2025
…ew settings in SmolDocling API. Improve the documentation. (#37) * chore: Change the pinning of docling Signed-off-by: Nikos Livathinos <[email protected]> * fix: Fix the modalities supported for DPBench, OmniDocBench, DLNv1. Clean up code. Signed-off-by: Nikos Livathinos <[email protected]> * docs: Update documentation to have all benchmarks in separate md files and place links in Readme. Signed-off-by: Nikos Livathinos <[email protected]> * fix: Change the initialization of the create_smol_docling_converter() to allow flash-attn Signed-off-by: Nikos Livathinos <[email protected]> * docs: List benchmarks in the main readme with short description. Fix broken links in the documentation. Signed-off-by: Nikos Livathinos <[email protected]> * docs: Fix broken link in Readme. Signed-off-by: Nikos Livathinos <[email protected]> * chore: Update lock file Signed-off-by: Nikos Livathinos <[email protected]> * fix: Add debug code to dump the predicted text in create_dlnv1_e2e_dataset() Signed-off-by: Nikos Livathinos <[email protected]> * chore: Update toml to pin docling with branch and extras Signed-off-by: Nikos Livathinos <[email protected]> * fix: Disable the generation of VLM text debugging files for DLNv1 benchmark Signed-off-by: Nikos Livathinos <[email protected]> * chore: Update toml to docling v2.25.0 with vln extra Signed-off-by: Nikos Livathinos <[email protected]> --------- Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Yusik Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the improvements in Readme from #35.
Additionally:
VlmPipelineOptions()to supportflash_attn.