Fix to gracefully fail in case git-lfs is not installed #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…talled Signed-off-by: Maksym Lysak <[email protected]>
maxmnemonic
requested review from
cau-git and
PeterStaar-IBM
and removed request for
cau-git and
PeterStaar-IBM
PeterStaar-IBM
approved these changes
Jan 6, 2025
cau-git
added a commit
that referenced
this pull request
Jan 7, 2025
* adding the omnidocbench benchmarkl Signed-off-by: Peter Staar <[email protected]> * added the table-parsing in omnidocbench Signed-off-by: Peter Staar <[email protected]> * finished the OmniDocBench implementation Signed-off-by: Peter Staar <[email protected]> * reformatted the code Signed-off-by: Peter Staar <[email protected]> * updated the README Signed-off-by: Peter Staar <[email protected]> * updated the README and the cli Signed-off-by: Peter Staar <[email protected]> * clean up the DP-Bench example Signed-off-by: Peter Staar <[email protected]> * made the DPBench and OmniDocBench follow the same example code Signed-off-by: Peter Staar <[email protected]> * reformatted the code Signed-off-by: Peter Staar <[email protected]> * cleaned up the dp-bench create script Signed-off-by: Peter Staar <[email protected]> * added the ability to see the clusters and reading order for layout Signed-off-by: Peter Staar <[email protected]> * reformatted the code Signed-off-by: Peter Staar <[email protected]> * working on making datasets from pdf collections Signed-off-by: Peter Staar <[email protected]> * added the package_pdfs example Signed-off-by: Peter Staar <[email protected]> * added the FinTabNet-OTSL benchmark Signed-off-by: Peter Staar <[email protected]> * reformatted the code Signed-off-by: Peter Staar <[email protected]> * added the fintabnet example evaluation Signed-off-by: Peter Staar <[email protected]> * updated the README fort FinTabNet Signed-off-by: Peter Staar <[email protected]> * updated the README Signed-off-by: Peter Staar <[email protected]> * refactored the table evaluations Signed-off-by: Peter Staar <[email protected]> * added the text inclusion in the table prediction Signed-off-by: Peter Staar <[email protected]> * fixed the header of the HTML Signed-off-by: Peter Staar <[email protected]> * reformatted the code Signed-off-by: Peter Staar <[email protected]> * fix: Formatting and unused code cleanup Signed-off-by: Christoph Auer <[email protected]> * feat: Extend the CLI to create the OMNIDOCBENCH datasets for the layout and tableformer modalities Signed-off-by: Nikos Livathinos <[email protected]> * Added exit to benchmark end-to-end scripts in case git-lfs is not installed (#5) Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]> * fix: Use TableStructureModel from docling, use backends, fix boundingbox coordinates Signed-off-by: Christoph Auer <[email protected]> * Reinstate layout test on dpbench Signed-off-by: Christoph Auer <[email protected]> * Comments Signed-off-by: Christoph Auer <[email protected]> * Comments Signed-off-by: Christoph Auer <[email protected]> * Remove unused code Signed-off-by: Christoph Auer <[email protected]> * Remove more unused code Signed-off-by: Christoph Auer <[email protected]> * Fixes for Omnidoc Signed-off-by: Christoph Auer <[email protected]> * Fixes for layout eval bounding boxes Signed-off-by: Christoph Auer <[email protected]> * More fixes for OmniDoc, README updates Signed-off-by: Christoph Auer <[email protected]> * More fixes for OmniDoc, README updates Signed-off-by: Christoph Auer <[email protected]> * Replace git-lsf with HF snapshot_download Signed-off-by: Christoph Auer <[email protected]> --------- Signed-off-by: Peter Staar <[email protected]> Signed-off-by: Christoph Auer <[email protected]> Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Christoph Auer <[email protected]> Co-authored-by: Nikos Livathinos <[email protected]> Co-authored-by: Maxim Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exit to benchmark end-to-end scripts in case git-lfs is not installed