Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCF: Issue #273: add a DUNEDAQ_DB_PATH environment variable to dbt-wo… #274

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jcfreeman2
Copy link
Collaborator

…rkarea-env

@jcfreeman2 jcfreeman2 requested a review from eflumerf April 17, 2024 13:42
@jcfreeman2
Copy link
Collaborator Author

In order to test this:

  • Rather than setting up daq-buildtools with the usual setup_dbt ... chant, you want to clone this repo, get onto this feature branch, and then source its env.sh
  • Set up a work area based on the test nightly NFDT_DEV_240416_A9, as well as spack load dbe, of course. This work area uses Spack builds of the packages daq-cmake, oks, dbe and oksconfgen on their johnfreeman/daq-buildtools_issue273_oks_paths branches, same name as this daq-buildtools branch
  • Among other tests, confirm that if you're working with both coredal and appdal in your work area, that edits to coredal schema objects through appdal schema modify the coredal schema file in-place in the checked out repo, not the installed coredal schema
  • Also check that if you add a user-defined directory to prepend to $DUNEDAQ_DB_PATH, that if you then start adding new packages, dbt-workarea-env will get your user-defined directory to remain at the head of the colon-separated paths

Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that dbe_main and schemaeditor work as expected with files loading from the sourcecode area when present.

@eflumerf
Copy link
Member

Only possible issue I see is that now OKS does load from sourcecode by preference ALL the time
So generate_modules_test test-session df-01 sourcecode/appdal/test/config/test-session.xml is loading (for example) /home/eflumerf/Desktop/dune-daq-base/dev-dbe/sourcecode/appdal/test/config/trigger-segment.data.xml
I think this is fine, so you don't even need to build again after editing configurations before running, but something to be aware of

@jcfreeman2
Copy link
Collaborator Author

Merging after Eric's comments here and on Slack.

@jcfreeman2 jcfreeman2 merged commit 38d5bbe into develop Apr 17, 2024
1 check passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/daq-buildtools_issue273_oks_paths branch April 17, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants