Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to appfwk configuration classes no longer being singletons but … #53

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

eflumerf
Copy link
Member

…paramters of init method

@eflumerf eflumerf requested a review from gcrone December 11, 2023 16:20
@eflumerf eflumerf self-assigned this Dec 11, 2023
@eflumerf
Copy link
Member Author

This should not be merged until after DUNE-DAQ/appfwk#267

Copy link
Contributor

@gcrone gcrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

eflumerf and others added 7 commits December 11, 2023 12:31
…noreply.github.com>

Date:   Fri Sep 8 12:15:30 2023 -0500

    syncing ; previous commit: Author: Pengfei Ding <[email protected]>
    Date:   Tue Aug 29 17:25:57 2023 -0500

        syncing ; previous commit: Author: Pengfei Ding <[email protected]>
        Date:   Tue Aug 29 16:30:46 2023 -0500

            syncing dunedaq-develop-cpp-ci.yml; previous commit: Merge: f21e155 c947b06
            Author: eflumerf <[email protected]>
            Date:   Mon Jul 3 07:41:31 2023 -0500

                Merge pull request #51 from DUNE-DAQ/eflumerf/VersionBump

                Update version number
Date:   Tue Dec 12 19:37:54 2023 -0600

    syncing ; previous commit: Author: Pengfei Ding <[email protected]>
    Date:   Fri Sep 8 12:15:30 2023 -0500

        syncing ; previous commit: Author: Pengfei Ding <[email protected]>
        Date:   Tue Aug 29 17:25:57 2023 -0500

            syncing ; previous commit: Author: Pengfei Ding <[email protected]>
            Date:   Tue Aug 29 16:30:46 2023 -0500

                syncing dunedaq-develop-cpp-ci.yml; previous commit: Merge: f21e155 c947b06
                Author: eflumerf <[email protected]>
                Date:   Mon Jul 3 07:41:31 2023 -0500

                    Merge pull request #51 from DUNE-DAQ/eflumerf/VersionBump

                    Update version number
Date:   Fri Dec 15 18:07:22 2023 -0600

    syncing ; previous commit: Author: John Freeman <[email protected]>
    Date:   Tue Dec 12 19:37:54 2023 -0600

        syncing ; previous commit: Author: Pengfei Ding <[email protected]>
        Date:   Fri Sep 8 12:15:30 2023 -0500

            syncing ; previous commit: Author: Pengfei Ding <[email protected]>
            Date:   Tue Aug 29 17:25:57 2023 -0500

                syncing ; previous commit: Author: Pengfei Ding <[email protected]>
                Date:   Tue Aug 29 16:30:46 2023 -0500

                    syncing dunedaq-develop-cpp-ci.yml; previous commit: Merge: f21e155 c947b06
                    Author: eflumerf <[email protected]>
                    Date:   Mon Jul 3 07:41:31 2023 -0500

                        Merge pull request #51 from DUNE-DAQ/eflumerf/VersionBump

                        Update version number
…eman <[email protected]>

Date:   Mon Jan 8 17:40:22 2024 -0600

    syncing ; previous commit: Author: John Freeman <[email protected]>
    Date:   Fri Dec 15 18:07:22 2023 -0600

        syncing ; previous commit: Author: John Freeman <[email protected]>
        Date:   Tue Dec 12 19:37:54 2023 -0600

            syncing ; previous commit: Author: Pengfei Ding <[email protected]>
            Date:   Fri Sep 8 12:15:30 2023 -0500

                syncing ; previous commit: Author: Pengfei Ding <[email protected]>
                Date:   Tue Aug 29 17:25:57 2023 -0500

                    syncing ; previous commit: Author: Pengfei Ding <[email protected]>
                    Date:   Tue Aug 29 16:30:46 2023 -0500

                        syncing dunedaq-develop-cpp-ci.yml; previous commit: Merge: f21e155 c947b06
                        Author: eflumerf <[email protected]>
                        Date:   Mon Jul 3 07:41:31 2023 -0500

                            Merge pull request #51 from DUNE-DAQ/eflumerf/VersionBump

                            Update version number
@eflumerf eflumerf merged commit 8be9374 into feature/OKS Jan 9, 2024
@eflumerf eflumerf deleted the eflumerf/NoOKSSingletons branch January 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants