Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the trigger documentation from v4 to v5 #365

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Conversation

ArturSztuc
Copy link
Contributor

@ArturSztuc ArturSztuc commented Nov 14, 2024

Updating the trigger documentation from v4 to v5:
Removing a lot of obsolete text, removing some repetitions, adding/updating information for v5, trying to make the document a bit more concise.

Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and spelling suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/trigger-alg-howto.md Outdated Show resolved Hide resolved
docs/trigger-alg-howto.md Outdated Show resolved Hide resolved
@ArturSztuc ArturSztuc requested a review from aeoranday November 18, 2024 15:18
@ArturSztuc
Copy link
Contributor Author

Thanks for finding all of these @aeoranday, I agreed with all the suggestions & updated the document.

Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ArturSztuc ArturSztuc merged commit 989320d into develop Nov 19, 2024
1 check passed
@ArturSztuc ArturSztuc deleted the asztuc/doc_update branch November 19, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants