Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating RTCM receiver pubsub to use IOM receiver tags #368

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

ArturSztuc
Copy link
Contributor

Requires the following PRs:

  1. Add a "tag" parameter to ConnectionId that can be used to differentiate iomanager#79
  2. Using iomanager:eflumerf/Issue70_idea, have a test configuration with listrev#63

Fixes issue in a comment described in #364, which is a result of DUNE-DAQ/iomanager#70.

In short: Only one subscriber was allowed in pubsub connection. When trying to run with two RandomTCMakers, both using kTimeSync, they would both try to connect response/callback function to the same TimeSync connection pubsub, resulting in a crash.

The PRs above add new feature in IOManager to allow multiple receivers for a connection, and this PR makes RandomTCMakers using this new feature.

Tested by running two RandomTCMakers with kTimeSync, and checkout the log messages / output HDF5 file.
Might need few other packages (e.g. appfwk) for others to test.

Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and the regression tests still pass. Only concern is since this depends on iomanager, it will be tricky to incorporate into existing areas until the nightly is cut.

@ArturSztuc
Copy link
Contributor Author

Tested again with the new nightly. Doesn't require iomanager (and all of its dependencies) to be pulled through anymore, so won't cause build issues for people pulling the trigger repository.
Merging.

@ArturSztuc ArturSztuc merged commit aefe766 into develop Nov 20, 2024
1 check failed
@ArturSztuc ArturSztuc deleted the asztuc/iom_pubsub_rtcm_fix branch November 20, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants