Patch: Adding horn current and nupdg to cov yaml files #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to convert xml files properly. Added cov xml file used by Liban. Added a python script to split the cov yaml files by parameter groups and detectors.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dbarrow257
requested changes
Feb 13, 2025
There was a problem hiding this comment.
LGTM - Just a couple of file moves.
Shouldn't
MaCh3_DUNE/configs/EventRates_Beam.yaml
Line 10 in 6a0be3f
configs/CovObjs/split_yaml.py
Outdated
There was a problem hiding this comment.
Could you move this to utils/xsecMatrixMaker to avoid cluttering the configs directory with scripts
There was a problem hiding this comment.
Should this be moved under tdr_covs?
…ify input file and output folder; edited xsec cov file specified in EventRates_Beam.yaml and changed global step scale to match TDR value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Adding horn current and nupdg info to xsec yaml files and modified xml2yaml.py.
Changes or fixes:
xml2yaml.pyto account for horn current and nupdg.tdr_covs_grouped.yaml. I manually addedParameterGroupinfo to the yaml file.tdr_covs_grouped.yamlto various combinations of [ND, FD, ND+FD] and [Flux, Xsec, DetSys]. The location of the script might be better moved to/utils.