Kalman simplest b field #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkio
reviewed
Jan 21, 2025
src/TMS_Bar.cpp
Outdated
| @@ -76,11 +79,11 @@ bool TMS_Bar::FindModules(double xval, double yval, double zval) { | |||
| // Do a sanity check (CHEATING!) | |||
| // Know the bars are 1cm in z and 3.542cm in x | |||
| if (zw != 10 || (xw != 35.42 && yw != 35.42)) { | |||
| std::cerr << "width of " << NodeName << " not as expected!" << std::endl; | |||
| std::cerr << "width of " << NodeName << " not as expected! (1cm deep, 1 3.542cm wide)" << std::endl; | |||
| std::cerr << "xwidth: " << xw << std::endl; | |||
| std::cerr << "ywidth: " << yw << std::endl; | |||
| std::cerr << "zwidth: " << zw << std::endl; | |||
There was a problem hiding this comment.
This code (everything under the sanity check) was explicitly removed from a previous version. It breaks with any changes to the geometry. See some of the newer code here. I'm confused how this PR is adding this back in, and why it isn't labeled as an addition
|
@xiaoyan1997, I think you'd need to merge the conflicts before we can properly review. I definitely don't want to reintroduce the old sanity check which we removed. That will cause crashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.