Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want z position cut to be more liberal for reco tracks #93

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jdkio
Copy link
Contributor

@jdkio jdkio commented Apr 18, 2024

For reco tracks, we can't be sure the front/end of the reco track is the primary track. Like the reco track might be two particles, and the end of the track is mostly particle 2. But we want the true track position to point to the nearest matching z position of the "primary" particle that makes up the track, ie the one contributing the most true energy. So expand the cut so it will find the nearest true position regardless of distance.

Also expands the z cut in general for true position starting/ending at TMS/LAr so that we have more info. But I don't think we care if we're too far because we can use birth/death position for those particles

@jdkio jdkio requested a review from LiamOS April 18, 2024 20:03
Copy link
Member

@LiamOS LiamOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

May be useful to add a default value for max_z_dist in GetMomentumAtZ() so it defaults to behaving like the previous version.

@LiamOS LiamOS merged commit cf8230a into main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants