Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disabled channels filter #166

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add disabled channels filter #166

wants to merge 2 commits into from

Conversation

diaza
Copy link
Member

@diaza diaza commented Feb 27, 2025

Filters out disabled channels.
The input file is a json dictionary where the keys are strings '<io_group>-<io_channel>-<chip_id>' and the values are lists of the channel_ids. The file format can be updated in the future.
The list of disabled channels has been added as an additional datatype in 'geometry_info', and the filtering is done in the event building stage (in the same line where parity == 0 is enforced).

@diaza
Copy link
Member Author

diaza commented Feb 27, 2025

Just noticed the conflict, let me fix that

@diaza
Copy link
Member Author

diaza commented Feb 27, 2025

fixed

@jaafar-chakrani
Copy link
Member

Thanks Alex! Two things that we need to take into account still:

  1. The disabled channel list is extracted from the 2x2 config files, which means that io_channel will not always be the same for the chips in the simulation file. One way around it is to convert io_channel both in the disabled channel list and the packet file to tile_id using: tile_id = (io_channel - 1) // 4 + 1, and this way you can locatethe chip/channel on a tile independently from the hydra network.
  2. The disabled channel list does not include fully disabled ASICs. I will provide that as well, but a similar question regarding the io_channel of disabled chips comes to mind. So I will probably wait for a proposed solution to the issue above before I make a file accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants