Refactor attack methods and NullWeapon

lecture_4/homework/app/models/warrior.rb

@@ -14,4 +14,12 @@ class Warrior < ApplicationRecord
 
   scope :alive, -> { where('death_date IS NULL') }
   scope :dead, -> { where('death_date IS NOT NULL') }
+
+  def attack
+    "#{type.demodulize} #{name} attacked with #{weapon_null_check.type.demodulize}"
+  end
+
+  def null_weapon_check
+    weapon || NullWeapon.new
+  end
 end

lecture_4/homework/app/models/warriors/hussar.rb

@@ -3,9 +3,5 @@
 module Warriors
   class Hussar < Warrior
     attribute :preferred_weapon_kind, :string, default: :ranged
-
-    def attack
-      "Hussar #{name} charged while yielding #{weapon.type.demodulize}"
-    end
   end
 end

lecture_4/homework/app/models/warriors/samurai.rb

@@ -3,9 +3,5 @@
 module Warriors
   class Samurai < Warrior
     attribute :preferred_weapon_kind, :string, default: :melee
-
-    def attack
-      "Samurai #{name} attacked with #{weapon.type.demodulize}"
-    end
   end
 end

lecture_4/homework/app/nulls/null_weapon.rb

@@ -0,0 +1,15 @@
+# frozen_literal_string: true
+
+class NullWeapon
+  def type
+    'Oops, no weapon.'
+  end
+
+  def range
+    nil
+  end
+
+  def damage
+    nil
+  end
+end