Zad4 #124
Open
Zad4 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Apr 15, 2019
| def type | ||
| 'no weapon' | ||
| end | ||
| end |
There was a problem hiding this comment.
Null Object dla wojowników bez broni
ghost
commented
Apr 15, 2019
| def self.exp_desc(relation: Mercenary) | ||
| relation.order(experience: :desc) | ||
| end | ||
| end |
There was a problem hiding this comment.
Query dla najemników dla poprawienia przejrzystości kodu
ghost
commented
Apr 15, 2019
|
|
||
| attributes :name, :price, :experience, :available_from, | ||
| :preferred_weapon_kind | ||
| end |
There was a problem hiding this comment.
Obowiązkowy serializer dla najemników
| clan: clan, | ||
| building: building, | ||
| mercenary: @mercenary).call | ||
| end |
There was a problem hiding this comment.
Service Objects dla poprawienia przejrzystości kodu
|
Bardzo dobrze rozwiązana praca domowa. Jedyne czego mi tutaj zabrakło to:
|
h4nky
reviewed
Apr 16, 2019
| # frozen_string_literal: true | ||
|
|
||
| class WarriorCreator | ||
| def initialize(relation: Warrior, mercenary:, building:, clan:) |
There was a problem hiding this comment.
Oczekujemy że WarriorCreator stworzy nam obiekt wojownika więc przekazywanie do niego Klasy z której ma tworzyć jest zbędne.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.