Highlight (import, export module references)

[zoodogood]

The import path now has the same highlighting as the string literal (string.unquoted.module-reference.civet). Previously it could be colored with anything

Before pull

• Highlight export a, b from x too
• Backward Import/Export from x import {a, b}
• import default, {} from x
• Replace \S to [^;\\s=>]+
  

---

I have been unable to determine the correct method for intercepting the block completion

with
  type: "json"

so this part is not part of the import expression, which is semantically wrong. Any criticism is welcome, I'm inexperienced

[edemaine]

Could you rebase against our main branch? There seems to be a lot of other commits here.

[zoodogood]

Oops. I'm redoing the pull request now. Or does it merge into pure history?

[zoodogood]

Yeah, I noticed that, too. It's gonna take me a little while

[edemaine]

If you setup a remote of upstream to refer to our repo/fork (git remote add upstream [email protected]:DanielXMoore/Civet.git), then git rebase -i upstream/main, then git push -f (after checking everything is still OK), the PR will update.

[zoodogood]

If you setup a remote of upstream to refer to our repo/fork (git remote add upstream [email protected]:DanielXMoore/Civet.git), then git rebase -i upstream/main, then git push -f (after checking everything is still OK), the PR will update.

Thank you, that helped.

[edemaine]

Not related to this PR, but while I look at this, we have a bunch more for keywords, such as each and the reducers sum etc.

[zoodogood]

@edemaine I think it's ready. Can you check?

Thank you for taking the time to check the code and suggesting ways to improve it

[edemaine]

\\{(.|\\n)*\\} seems rather inclusive. Perhaps (.|\\n) should be replaced by [^{}]? Or at least * should be *?, like the quoted string regexes.

I also realize that, if you're just trying to match unquoted module references here, you don't actually need |\".+?\"|'.+?'. (If you keep them, shouldn't + be *?)