Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alternate browser location in _WD_UpdateDriver #225

Closed
wants to merge 16 commits into from
Closed

Support alternate browser location in _WD_UpdateDriver #225

wants to merge 16 commits into from

Conversation

Danp2
Copy link
Owner

@Danp2 Danp2 commented Feb 26, 2022 •
edited
Loading

Pull request

Proposed changes

Support alternate browser location in _WD_UpdateDriver

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!

This is simply a reminder of what we are going to look for before merging your code.

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Unable to update webdriver for portable / alt versions of browser

What is the new behavior?

_WD_UpdateDriver now accepts the full path of the browser executable for $sBrowser parameter

Additional context

None

System under test

N/A

Danp2 and others added 16 commits February 22, 2022 14:31
@Danp2
Array of supported browsers
68941cf
@Danp2
_WD_GetBrowserVersion: Eliminate hardcoding
0de1eed
@Danp2
_WD_UpdateDriver: Partial elimination of hardcoding
ed1c472
@mlipok
wd_demo.au3 Opera first commit (#214)
30e351a
@Danp2
Expand and move Support Browsers array
96050bd
@Danp2
Implement $_WD_BROWSER* enum
10b367c
@Danp2
Merge branch 'master' into supportOpera
172696e
@Danp2
Utilize $_WD_BROWSER_Name
c396767
@mlipok
__WD_CapabilitiesInitialize + 'operaOptions' (#217)
23a522f 
* __WD_CapabilitiesInitialize + 'operaOptions'

* using $_WD_SupportedBrowsers

* 'edge' >> 'msedge' ScriptBreakingChange
@Danp2
Readme update for opera (#216)
2084968
@mlipok
wd_core.au3 - operaOptions > goog:chromeOptions (#221)
1279a75 
related to @Danp2  findings:
#220 (comment)
@mlipok
added _WD_GetBrowserPath() with Opera path support
2005392
@Danp2
Refactoring
00ac564 
- Use HKLM and HKCU
- Remove Opera specifc coding
- Add header
@mlipok
_WD_GetBrowserPath: fix, refactor, comments
62d9b13
@Danp2
Merge branch 'pr/223' into dp_updatedriver
dece4ba
@Danp2
_WD_UpdateDriver: Support alternate browser location
a109320
@Danp2 Danp2 closed this Feb 26, 2022
@Danp2 Danp2 deleted the dp_updatedriver branch February 26, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Danp2 @mlipok