OPERA: _WD_UpdateDriver + __WD_UpdateExtractor #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlipok
commented
Mar 2, 2022
mlipok
commented
Mar 2, 2022
Danp2
reviewed
Mar 2, 2022
this was cross version errors - I miss some already done merged PR
mlipok
commented
Mar 2, 2022
Danp2
approved these changes
Mar 2, 2022
Danp2
added a commit
that referenced
this pull request
Mar 2, 2022
* Array of supported browsers * _WD_GetBrowserVersion: Eliminate hardcoding * _WD_UpdateDriver: Partial elimination of hardcoding * wd_demo.au3 Opera first commit (#214) * Expand and move Support Browsers array * Implement $_WD_BROWSER* enum * Utilize $_WD_BROWSER_Name * __WD_CapabilitiesInitialize + 'operaOptions' (#217) * __WD_CapabilitiesInitialize + 'operaOptions' * using $_WD_SupportedBrowsers * 'edge' >> 'msedge' ScriptBreakingChange * Readme update for opera (#216) * wd_core.au3 - operaOptions > goog:chromeOptions (#221) related to @Danp2 findings: #220 (comment) * added _WD_GetBrowserPath() with Opera path support (#223) * _WD_GetBrowserPath: Eliminate browser specific code * _WD_UpdateDriver: Support alternate browser location (#226) * wd_demo.au3 - SetupOpera() suplemented + fixes (#218) * Update change log (#230) * Fix [Unreleased] header * Update CHANGELOG.md * _WD_UpdateDriver: Eliminate remaining hardcoding (#231) * Expand $_WD_SupportedBrowsers * Add __WD_GetLatestWebdriverInfo * _WD_UpdateDriver: Use __WD_GetLatestWebdriverInfo * OPERA: _WD_GetBrowserVersion/Path refactoring (#235) * $_WD_ERROR_NotSupported * using $iIndex = @Extended * OPERA: _WD_UpdateDriver + __WD_UpdateExtractor (#236) * Opera final proposals (#237) Co-authored-by: Michał Lipok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Proposed changes
Support for unpacking opera driver which is placed in subfolder in zip archive
Checklist
Put an
xin the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!This is simply a reminder of what we are going to look for before merging your code.
Types of changes
Please check
xthe type of change your PR introduces:What is the current behavior?
it is not able to unpack opera driver
What is the new behavior?
support for unpacking exe file from subfolder
Additional context
#187
System under test
NOT RELATED