Recipe-App #18
Recipe-App #18
Conversation
Create Login page and registration page
Recipe app: Foodlist_Feature
Recipes list
Recipe details
Recipe app: Public_Recipes_Feature
Recipe-App: General_Shopping_List_Feature
Modify files in the app folder, Add button
Navigation
Modify files in app and config folder
Add styling
There was a problem hiding this comment.
Changes Required ♻️
Hi @johnkioko and @Daphineatim,
Nice job, you are almost there.
(Highlights) Good Points: 👍
- You documented your work professionally. ✔
- You used the correct workflow. ✔
- All linters checks are ok. ✔
(Changes Required) Aspects to improve: ♻️
- Please check the inline comments below.
[Optional] suggestions:
- Nothing to mention.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| </thead> | ||
| <tbody> | ||
| <% if recipe.foods.blank? %> | ||
| <h4 class="text-center">No foods available!</h4> | ||
| <% else %> | ||
| <% recipe.recipe_foods.each do |recipe_food| %> | ||
|
|
||
| <tr class="border-b"> | ||
| <td scope="row" class="px-6 py-4 whitespace-nowrap text-sm font-medium text-gray-900"></td> | ||
| <td class="text-sm text-gray-900 font-light px-6 py-4 whitespace-nowrap"> | ||
| <%= "#{recipe_food.quantity} #{recipe_food.food.measurement_unit}" %> |
There was a problem hiding this comment.
- There is an error raised while trying to open the
recipe show (details)page, Please fix that.
There was a problem hiding this comment.
STATUS: APPROVED ✔🍾🎉
Hello @johnkioko and @Daphineatim
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- You documented your work professionally.✔
You asked for the changes in a polite and friendly way. - Your linters are passing all the checks.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this project, we implemented the features below:
Login page and registration page:
Built with Devise.
Food list:
Displays a list of food added by the logged-in user as in the wireframe (for teams with only 2 people - display also quantity of a given food).
Leads to a form that allows users to add new food.
Recipes list:
Displays a list of recipes created by the logged-in user as in the wireframe.
Leads to recipe details.
If the user is the owner of the recipe, should allow the user to delete it.
Public recipe list:
Displays a list of all public recipes ordered by the newest as in the wireframe.
Lead to recipe details.
Recipe details:
If the recipe is public or the user is the owner of the recipe, should display the recipe details as in the wireframe.
If the user is the owner of the recipe, should lead to the form that allows the user to add new food.
Made sure there are no N+1 queries happening.
Created a navigation menu that allows users to open all of the pages you created.