Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN-385] Move listRuntimes over to new Sam permissions model - take 2 #4827

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LizBaldo
Copy link
Collaborator

Reverts #4823

JIRA ticket: https://broadworkbench.atlassian.net/browse/AN-385

This change was originally reverted, because it removed the ability to list deleted runtimes, which AOU RWB was making use of. See https://docs.google.com/document/d/1uivQxiSoFAyD7vpmFxes5037Dn1m0yx8VovsonylKYw/edit?tab=t.0#heading=h.mf724qma605n

Now that we confirmed that RWB can default to default settings instead of the user’s prior configurations, we can move forward with this PR again, with some added modifications to the swagger page to deprecate the isDeleted flag.

@LizBaldo LizBaldo requested a review from a team as a code owner February 10, 2025 16:40
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (1a00c81) to head (8ebc867).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4827      +/-   ##
===========================================
- Coverage    74.77%   74.62%   -0.16%     
===========================================
  Files          166      166              
  Lines        14800    14690     -110     
  Branches      1112     1158      +46     
===========================================
- Hits         11067    10962     -105     
+ Misses        3733     3728       -5     
Files with missing lines Coverage Δ
...orkbench/leonardo/db/RuntimeServiceDbQueries.scala 96.69% <100.00%> (+0.37%) ⬆️
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.87% <ø> (-0.02%) ⬇️
...h/leonardo/http/service/RuntimeServiceInterp.scala 91.73% <100.00%> (+0.19%) ⬆️
...leonardo/http/service/RuntimeV2ServiceInterp.scala 95.45% <100.00%> (-0.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a00c81...8ebc867. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant