Skip to content

Commit

Permalink
Update CODEOWNER following agent-shared-components split (#33477)
Browse files Browse the repository at this point in the history
  • Loading branch information
hush-hush authored Jan 31, 2025
1 parent e70c16d commit ee4c0bd
Show file tree
Hide file tree
Showing 98 changed files with 230 additions and 164 deletions.
18 changes: 18 additions & 0 deletions .ddqa/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,24 @@ github_team = "agent-shared-components"
github_labels = ["team/agent-shared-components"]
exclude_members = ["sgnn7", "truthbk", "cmourot"]

# Those will be uncommented once the proper issue types are created in JIRA.
#
# [teams."Agent Runtimes"]
# jira_project = "ARUN"
# jira_issue_type = "QA"
# jira_statuses = ["To Do", "In Progress", "Done"]
# github_team = "agent-runtimes"
# github_labels = ["team/agent-runtimes"]
# exclude_members = ["sgnn7", "cmourot"]
#
# [teams."Agent Configuration"]
# jira_project = "ACFG"
# jira_issue_type = "QA"
# jira_statuses = ["To Do", "In Progress", "Done"]
# github_team = "agent-configuration"
# github_labels = ["team/agent-configuration"]
# exclude_members = ["sgnn7"]

[teams."Agent Developer Tools"]
jira_project = "ADXT"
jira_issue_type = "QA"
Expand Down
165 changes: 87 additions & 78 deletions .github/CODEOWNERS

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/dependabot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ updates:
labels:
- dependencies
- dependencies-go
- team/agent-shared-components
- team/agent-configuration
- changelog/no-changelog
ignore:
# Ignore internal modules
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/buildimages-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
TMP_PR_BODY_PATH: /tmp/pr_body
GH_TOKEN: ${{ github.token }}
PR_TITLE: "[automated] ${{ steps.update_build_images.outputs.MESSAGE }}"
PR_LABELS: "go-update,team/agent-shared-components"
PR_LABELS: "go-update,team/agent-runtimes"
CURRENT_BUILDIMAGE_TAG: ${{ steps.current_buildimage_tag.outputs.BUILDIMAGE_TAG }}
IMAGES_ID: ${{ inputs.images_id }}
CURRENT_GO_VERSION: ${{ steps.current_go_version.outputs.GO_VERSION }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
TMP_PR_BODY_PATH: /tmp/pr_body
GH_TOKEN: ${{ steps.app-token.outputs.token }}
PR_TITLE: "[automated] Update golang.org/x/... dependencies"
PR_LABELS: "team/agent-shared-components,qa/done,changelog/no-changelog"
PR_LABELS: "team/agent-runtimes,qa/done,changelog/no-changelog"
GITHUB_REF: ${{ github.ref }}
run: |
# Generate the PR description
Expand Down
14 changes: 12 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -821,14 +821,24 @@ workflow:
- test/new-e2e/tests/remote-config/**/*
compare_to: main # TODO: use a variable, when this is supported https://gitlab.com/gitlab-org/gitlab/-/issues/369916

.on_asc_or_e2e_changes:
.on_arun_or_e2e_changes:
- !reference [.on_e2e_main_release_or_rc]
- changes:
paths:
- cmd/**/*
- pkg/**/*
- comp/**/*
- test/new-e2e/tests/agent-shared-components/**/*
- test/new-e2e/tests/agent-runtimes/**/*
compare_to: main # TODO: use a variable, when this is supported https://gitlab.com/gitlab-org/gitlab/-/issues/369916

.on_acfg_or_e2e_changes:
- !reference [.on_e2e_main_release_or_rc]
- changes:
paths:
- cmd/**/*
- pkg/**/*
- comp/**/*
- test/new-e2e/tests/agent-configuration//**/*
compare_to: main # TODO: use a variable, when this is supported https://gitlab.com/gitlab-org/gitlab/-/issues/369916

.on_subcommands_or_e2e_changes:
Expand Down
2 changes: 1 addition & 1 deletion .gitlab/JOBOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ prepare_secagent_ebpf_functional_tests* @DataDog/agent-security
protobuf_test @DataDog/multiple

# Send count metrics about Golang dependencies
golang_deps_send_count_metrics @DataDog/agent-shared-components
golang_deps_send_count_metrics @DataDog/agent-runtimes
# Golang dependency diff generation
golang_deps_diff @DataDog/ebpf-platform
golang_deps_commenter @DataDog/ebpf-platform
Expand Down
23 changes: 16 additions & 7 deletions .gitlab/e2e/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,23 @@ new-e2e-remote-config:
TARGETS: ./tests/remote-config
TEAM: remote-config

new-e2e-agent-shared-components:
new-e2e-agent-configuration:
extends: .new_e2e_template_needs_deb_windows_x64
rules:
- !reference [.on_asc_or_e2e_changes]
- !reference [.on_acfg_or_e2e_changes]
- !reference [.manual]
variables:
TARGETS: ./tests/agent-shared-components
TEAM: agent-shared-components
TARGETS: ./tests/agent-configuration
TEAM: agent-configuration

new-e2e-agent-runtimes:
extends: .new_e2e_template_needs_deb_windows_x64
rules:
- !reference [.on_arun_or_e2e_changes]
- !reference [.manual]
variables:
TARGETS: ./tests/agent-runtimes
TEAM: agent-runtimes

new-e2e-agent-subcommands:
extends: .new_e2e_template_needs_deb_windows_x64
Expand All @@ -182,7 +191,7 @@ new-e2e-agent-subcommands:
- !reference [.manual]
variables:
TARGETS: ./tests/agent-subcommands
TEAM: agent-shared-components
TEAM: agent-configuration
parallel:
matrix:
- EXTRA_PARAMS: --run "Test(Linux|Windows)StatusSuite"
Expand All @@ -203,11 +212,11 @@ new-e2e-fips-compliance-test:
- qa_agent_fips
- deploy_deb_testing-a7_x64
rules:
- !reference [.on_asc_or_e2e_changes]
- !reference [.on_arun_or_e2e_changes]
- !reference [.manual]
variables:
TARGETS: ./tests/fips-compliance
TEAM: agent-shared-components
TEAM: agent-runtimes

new-e2e-windows-service-test:
extends: .new_e2e_template
Expand Down
24 changes: 19 additions & 5 deletions comp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Click the links for more documentation.

## [comp/agent](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/agent) (Component Bundle)

*Datadog Team*: agent-shared-components
*Datadog Team*: agent-runtimes

Package agent implements the "agent" bundle,

Expand Down Expand Up @@ -46,13 +46,13 @@ Package demultiplexerendpoint component provides the /dogstatsd-contexts-dump AP

### [comp/aggregator/diagnosesendermanager](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/aggregator/diagnosesendermanager)

*Datadog Team*: agent-shared-components
*Datadog Team*: agent-configuration

Package diagnosesendermanager defines the sender manager for the local diagnose check

## [comp/api](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/api) (Component Bundle)

*Datadog Team*: agent-shared-components
*Datadog Team*: agent-runtimes

Package api implements the "api" bundle,

Expand Down Expand Up @@ -102,7 +102,7 @@ Package collector defines the collector component.

## [comp/core](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core) (Component Bundle)

*Datadog Team*: agent-shared-components
*Datadog Team*: agent-runtimes

Package core implements the "core" bundle, providing services common to all
agent flavors and binaries.
Expand All @@ -119,19 +119,27 @@ Package autodiscovery provides the autodiscovery component for the Datadog Agent

### [comp/core/config](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/config)

*Datadog Team*: agent-configuration

Package config implements a component to handle agent configuration. This
component temporarily wraps pkg/config.

### [comp/core/configsync](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/configsync)

*Datadog Team*: agent-configuration

Package configsync implements synchronizing the configuration using the core agent config API

### [comp/core/flare](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/flare)

*Datadog Team*: agent-configuration

Package flare implements a component to generate flares from the agent.

### [comp/core/gui](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/gui)

*Datadog Team*: agent-configuration

Package gui provides the GUI server component for the Datadog Agent.

### [comp/core/healthprobe](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/healthprobe)
Expand Down Expand Up @@ -166,14 +174,20 @@ status and emit flare data

### [comp/core/secrets](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/secrets)

*Datadog Team*: agent-configuration

Package secrets decodes secret values by invoking the configured executable command

### [comp/core/settings](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/settings)

*Datadog Team*: agent-configuration

Package settings defines the interface for the component that manage settings that can be changed at runtime

### [comp/core/status](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/status)

*Datadog Team*: agent-configuration

Package status displays information about the agent.

### [comp/core/sysprobeconfig](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/core/sysprobeconfig)
Expand Down Expand Up @@ -282,7 +296,7 @@ send logs.

## [comp/metadata](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/metadata) (Component Bundle)

*Datadog Team*: agent-shared-components
*Datadog Team*: agent-configuration

Package metadata implements the "metadata" bundle, providing services and support for all the metadata payload sent
by the Agent.
Expand Down
2 changes: 1 addition & 1 deletion comp/agent/autoexit/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Package autoexit lets setup automatic shutdown mechanism if necessary
package autoexit

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type.
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/agent/bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/util/fxutil"
)

// team: agent-shared-components
// team: agent-runtimes

// Bundle defines the fx options for this bundle.
func Bundle(params jmxloggerimpl.Params) fxutil.BundleOptions {
Expand Down
2 changes: 1 addition & 1 deletion comp/agent/expvarserver/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Package expvarserver contains the component type for the expVar server.
package expvarserver

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type.
type Component interface{}
2 changes: 1 addition & 1 deletion comp/aggregator/diagnosesendermanager/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/aggregator/sender"
)

// team: agent-shared-components
// team: agent-configuration

// Component is the component type.
// This component must not be used with demultiplexer.Component
Expand Down
2 changes: 1 addition & 1 deletion comp/api/api/def/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"go.uber.org/fx"
)

// team: agent-shared-components
// team: agent-runtimes

// TODO(components):
// * Lifecycle can't be used atm because:
Expand Down
2 changes: 1 addition & 1 deletion comp/api/authtoken/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/util/option"
)

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type.
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/api/bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package api

import "github.com/DataDog/datadog-agent/pkg/util/fxutil"

// team: agent-shared-components
// team: agent-runtimes

// TODO(components): empty bundle for the linter. Might be removed later

Expand Down
2 changes: 1 addition & 1 deletion comp/core/agenttelemetry/def/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Package agenttelemetry implements a component to generate Agent telemetry
package agenttelemetry

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/util/option"
)

// team: agent-shared-components
// team: agent-runtimes

// Bundle defines the fx options for this bundle.
func Bundle() fxutil.BundleOptions {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/bundle_mock.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/util/fxutil"
)

// team: agent-shared-components
// team: agent-runtimes

// MakeMockBundle returns a core bundle with a customized set of fx.Option including sane defaults.
func MakeMockBundle(logParams, logger fx.Option) fxutil.BundleOptions {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/config/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/util/fxutil"
)

// team: agent-shared-components
// team: agent-configuration

// Component is the component type.
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/configsync/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Package configsync implements synchronizing the configuration using the core agent config API
package configsync

// team: agent-shared-components
// team: agent-configuration

// Component is the component type.
type Component interface{}
2 changes: 1 addition & 1 deletion comp/core/flare/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"github.com/DataDog/datadog-agent/pkg/util/fxutil"
)

// team: agent-shared-components
// team: agent-configuration

// Component is the component type.
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/gui/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Package gui provides the GUI server component for the Datadog Agent.
package gui

// team: agent-shared-components
// team: agent-configuration

// Component is the component type.
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/healthprobe/def/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Package healthprobe implements the health check server
package healthprobe

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type.
type Component interface {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/hostname/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package hostname

import "github.com/DataDog/datadog-agent/comp/core/hostname/hostnameinterface"

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type.
type Component = hostnameinterface.Component
2 changes: 1 addition & 1 deletion comp/core/hostname/hostnameinterface/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"context"
)

// team: agent-shared-components
// team: agent-runtimes

// Data contains hostname and the hostname provider
type Data struct {
Expand Down
2 changes: 1 addition & 1 deletion comp/core/log/def/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// logging output to `t.Log(..)`, for ease of investigation when a test fails.
package log

// team: agent-shared-components
// team: agent-runtimes

// Component is the component type.
type Component interface {
Expand Down
Loading

0 comments on commit ee4c0bd

Please sign in to comment.