Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] fix open with perm denied not reported #33634

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

safchain
Copy link
Contributor

@safchain safchain commented Jan 31, 2025

What does this PR do?

Move the dentry resolution upper in the call stack so that we can do a proper resolution in case of open with permission error.
Add a functional test to validate that we get event in case of permission access error.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 31, 2025

[Fast Unit Tests Report]

On pipeline 54730662 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 31, 2025

Uncompressed package size comparison

Comparison with ancestor e0a139dd8900943b88e681f4f0bebc6e39ad37ad

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.65MB 877.84MB 877.18MB 0.50MB
datadog-agent-x86_64-rpm 0.65MB 887.58MB 886.92MB 0.50MB
datadog-agent-x86_64-suse 0.65MB 887.58MB 886.92MB 0.50MB
datadog-agent-aarch64-rpm 0.65MB 875.35MB 874.69MB 0.50MB
datadog-agent-arm64-deb 0.65MB 865.63MB 864.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.02MB 59.02MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.51MB 56.51MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 456.45MB 456.45MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.84MB 93.84MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.91MB 93.91MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.91MB 93.91MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.89MB 89.89MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 89.96MB 89.96MB 0.50MB

Decision

❌ Failed

Currently this PR is blocked, you can reach out to #agent-delivery-help to get support/ask for an exception.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 31, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54730662 --os-family=ubuntu

Note: This applies to commit 9d2a8f1

Copy link

cit-pr-commenter bot commented Jan 31, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 98111b24-2d36-4f80-ae0c-1bb6f93b3d71

Baseline: e0a139d
Comparison: 9d2a8f1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.09 [+1.01, +1.17] 1 Logs
file_tree memory utilization +0.30 [+0.23, +0.37] 1 Logs
quality_gate_idle_all_features memory utilization +0.26 [+0.21, +0.32] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.20 [-0.69, +1.09] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.09 [-0.38, +0.56] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.69, +0.79] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.86, +0.92] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.80, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.29] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.95, +0.87] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.19 [-0.97, +0.59] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.24, -0.16] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.26 [-1.03, +0.50] 1 Logs
quality_gate_logs % cpu utilization -1.39 [-4.42, +1.63] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@safchain safchain force-pushed the safchain/fix-open-perm branch from b6e51cd to 21d5522 Compare February 3, 2025 12:46
@safchain safchain added the qa/done QA done before merge and regressions are covered by tests label Feb 3, 2025
@safchain safchain marked this pull request as ready for review February 3, 2025 16:53
@safchain safchain requested a review from a team as a code owner February 3, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant