[AGENTRUN-96] Update Go version to 1.23.6 #33934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/agent-devx-infra
team/agent-devx-loops
long review
GustavoCaso
changed the title
Gitlab CI Configuration ChangesModified Jobsvariables (configuration) variables:
AGENT_API_KEY_ORG2: agent-api-key-org-2
AGENT_APP_KEY_ORG2: agent-ci-app-key-org-2
AGENT_BINARIES_DIR: bin/agent
AGENT_GITHUB_APP: agent-github-app
AGENT_QA_E2E: agent-qa-e2e
API_KEY_ORG2: ci.datadog-agent.datadog_api_key_org2
ARTIFACT_DOWNLOAD_ATTEMPTS: 2
ATLASSIAN_WRITE: atlassian-write
BTFHUB_ARCHIVE_BRANCH: main
BUCKET_BRANCH: dev
CHANGELOG_COMMIT_SHA: ci.datadog-agent.gitlab_changelog_commit_sha
CHOCOLATEY_API_KEY: ci.datadog-agent.chocolatey_api_key
- CI_IMAGE_BTF_GEN: v55677206-ea52e48c
+ CI_IMAGE_BTF_GEN: v55750746-d62c2509
CI_IMAGE_BTF_GEN_SUFFIX: ''
- CI_IMAGE_DD_AGENT_TESTING: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_DD_AGENT_TESTING: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_DD_AGENT_TESTING_SUFFIX: ''
- CI_IMAGE_DEB_ARM64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_DEB_ARM64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_DEB_ARM64_SUFFIX: ''
- CI_IMAGE_DEB_ARMHF: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_DEB_ARMHF: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_DEB_ARMHF_SUFFIX: ''
- CI_IMAGE_DEB_X64: v55677206-ea52e48c
+ CI_IMAGE_DEB_X64: v55750746-d62c2509
CI_IMAGE_DEB_X64_SUFFIX: ''
- CI_IMAGE_DOCKER_ARM64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_DOCKER_ARM64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_DOCKER_ARM64_SUFFIX: ''
- CI_IMAGE_DOCKER_X64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_DOCKER_X64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_DOCKER_X64_SUFFIX: ''
- CI_IMAGE_GITLAB_AGENT_DEPLOY: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_GITLAB_AGENT_DEPLOY: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX: ''
- CI_IMAGE_LINUX_GLIBC_2_17_X64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_LINUX_GLIBC_2_17_X64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX: ''
- CI_IMAGE_LINUX_GLIBC_2_23_ARM64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_LINUX_GLIBC_2_23_ARM64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_LINUX_GLIBC_2_23_ARM64_SUFFIX: ''
- CI_IMAGE_RPM_ARM64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_RPM_ARM64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_RPM_ARM64_SUFFIX: ''
- CI_IMAGE_RPM_ARMHF: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_RPM_ARMHF: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_RPM_ARMHF_SUFFIX: ''
- CI_IMAGE_RPM_X64: v55677206-ea52e48c
+ CI_IMAGE_RPM_X64: v55750746-d62c2509
CI_IMAGE_RPM_X64_SUFFIX: ''
- CI_IMAGE_SYSTEM_PROBE_ARM64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_SYSTEM_PROBE_ARM64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_SYSTEM_PROBE_ARM64_SUFFIX: ''
- CI_IMAGE_SYSTEM_PROBE_X64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_SYSTEM_PROBE_X64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_SYSTEM_PROBE_X64_SUFFIX: ''
- CI_IMAGE_WIN_1809_X64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_WIN_1809_X64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_WIN_1809_X64_SUFFIX: ''
- CI_IMAGE_WIN_LTSC2022_X64: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ CI_IMAGE_WIN_LTSC2022_X64: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
CI_IMAGE_WIN_LTSC2022_X64_SUFFIX: ''
CLANG_LLVM_VER: 12.0.1
CLUSTER_AGENT_BINARIES_DIR: bin/datadog-cluster-agent
CLUSTER_AGENT_CLOUDFOUNDRY_BINARIES_DIR: bin/datadog-cluster-agent-cloudfoundry
CODECOV: codecov
CODECOV_TOKEN: ci.datadog-agent.codecov_token
CWS_INSTRUMENTATION_BINARIES_DIR: bin/cws-instrumentation
- DATADOG_AGENT_ARMBUILDIMAGES: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ DATADOG_AGENT_ARMBUILDIMAGES: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
DATADOG_AGENT_ARMBUILDIMAGES_SUFFIX: ''
- DATADOG_AGENT_BTF_GEN_BUILDIMAGES: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ DATADOG_AGENT_BTF_GEN_BUILDIMAGES: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
DATADOG_AGENT_BTF_GEN_BUILDIMAGES_SUFFIX: ''
- DATADOG_AGENT_BUILDIMAGES: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ DATADOG_AGENT_BUILDIMAGES: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
DATADOG_AGENT_BUILDIMAGES_SUFFIX: ''
DATADOG_AGENT_EMBEDDED_PATH: /opt/datadog-agent/embedded
- DATADOG_AGENT_SYSPROBE_BUILDIMAGES: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ DATADOG_AGENT_SYSPROBE_BUILDIMAGES: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
DATADOG_AGENT_SYSPROBE_BUILDIMAGES_SUFFIX: ''
- DATADOG_AGENT_WINBUILDIMAGES: v55677206-ea52e48c
? - ^^ ^^ ^^^^^
+ DATADOG_AGENT_WINBUILDIMAGES: v55750746-d62c2509
? ++ ^ ^^^^^ ^^
DATADOG_AGENT_WINBUILDIMAGES_SUFFIX: ''
DD_AGENT_TESTING_DIR: $CI_PROJECT_DIR/test/new-e2e/tests
DD_PKG_VERSION: latest
DEB_GPG_KEY: ci.datadog-agent.deb_signing_private_key_${DEB_GPG_KEY_ID}
DEB_GPG_KEY_ID: c0962c7d
DEB_GPG_KEY_NAME: Datadog, Inc. APT key
DEB_RPM_TESTING_BUCKET_BRANCH: testing
DEB_S3_BUCKET: apt.datad0g.com
DEB_SIGNING_PASSPHRASE: ci.datadog-agent.deb_signing_key_passphrase_${DEB_GPG_KEY_ID}
DEB_TESTING_S3_BUCKET: apttesting.datad0g.com
DOCKER_REGISTRY_LOGIN: ci.datadog-agent.docker_hub_login
DOCKER_REGISTRY_PWD: ci.datadog-agent.docker_hub_pwd
DOCKER_REGISTRY_RO: dockerhub-readonly
DOCKER_REGISTRY_URL: docker.io
DOGSTATSD_BINARIES_DIR: bin/dogstatsd
E2E_AZURE: e2e-azure
E2E_GCP: e2e-gcp
EXECUTOR_JOB_SECTION_ATTEMPTS: 2
FF_KUBERNETES_HONOR_ENTRYPOINT: true
FF_SCRIPT_SECTIONS: 1
FF_TIMESTAMPS: true
GENERAL_ARTIFACTS_CACHE_BUCKET_URL: https://dd-agent-omnibus.s3.amazonaws.com
GET_SOURCES_ATTEMPTS: 2
GITLAB_TOKEN: gitlab-token
GO_TEST_SKIP_FLAKE: 'true'
INSTALLER_TESTING_S3_BUCKET: installtesting.datad0g.com
INSTALL_SCRIPT_API_KEY_ORG2: install-script-api-key-org-2
INTEGRATION_WHEELS_CACHE_BUCKET: dd-agent-omnibus
KERNEL_MATRIX_TESTING_ARM_AMI_ID: ami-0b5f838a19d37fc61
KERNEL_MATRIX_TESTING_X86_AMI_ID: ami-05b3973acf5422348
KITCHEN_INFRASTRUCTURE_FLAKES_RETRY: 2
MACOS_GITHUB_APP_1: macos-github-app-one
MACOS_GITHUB_APP_2: macos-github-app-two
MACOS_S3_BUCKET: dd-agent-macostesting
OMNIBUS_BASE_DIR: /omnibus
OMNIBUS_GIT_CACHE_DIR: /tmp/omnibus-git-cache
OMNIBUS_PACKAGE_DIR: $CI_PROJECT_DIR/omnibus/pkg/
OMNIBUS_PACKAGE_DIR_SUSE: $CI_PROJECT_DIR/omnibus/suse/pkg
PROCESS_S3_BUCKET: datad0g-process-agent
RELEASE_VERSION_6: nightly
RELEASE_VERSION_7: nightly-a7
RESTORE_CACHE_ATTEMPTS: 2
RPM_GPG_KEY: ci.datadog-agent.rpm_signing_private_key_${RPM_GPG_KEY_ID}
RPM_GPG_KEY_ID: b01082d3
RPM_GPG_KEY_NAME: Datadog, Inc. RPM key
RPM_S3_BUCKET: yum.datad0g.com
RPM_SIGNING_PASSPHRASE: ci.datadog-agent.rpm_signing_key_passphrase_${RPM_GPG_KEY_ID}
RPM_TESTING_S3_BUCKET: yumtesting.datad0g.com
RUN_E2E_TESTS: auto
RUN_KMT_TESTS: auto
RUN_UNIT_TESTS: auto
S3_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME/$CI_PIPELINE_ID
S3_CP_CMD: aws s3 cp $S3_CP_OPTIONS
S3_CP_OPTIONS: --no-progress --region us-east-1 --sse AES256
S3_DD_AGENT_OMNIBUS_BTFS_URI: s3://dd-agent-omnibus/btfs
S3_DD_AGENT_OMNIBUS_JAVA_URI: s3://dd-agent-omnibus/openjdk
S3_DD_AGENT_OMNIBUS_LLVM_URI: s3://dd-agent-omnibus/llvm
S3_DSD6_URI: s3://dsd6-staging
S3_OMNIBUS_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-cache-build-stable
S3_OMNIBUS_GIT_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-git-cache-build-stable
S3_PERMANENT_ARTIFACTS_URI: s3://dd-ci-persistent-artefacts-build-stable/$CI_PROJECT_NAME
S3_PROJECT_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME
S3_RELEASE_ARTIFACTS_URI: s3://dd-release-artifacts/$CI_PROJECT_NAME/$CI_PIPELINE_ID
S3_RELEASE_INSTALLER_ARTIFACTS_URI: s3://dd-release-artifacts/datadog-installer/$CI_PIPELINE_ID
S3_SBOM_STORAGE_URI: s3://sbom-root-us1-ddbuild-io/$CI_PROJECT_NAME/$CI_PIPELINE_ID
SLACK_AGENT: slack-agent-ci
SMP_ACCOUNT: smp
STATIC_BINARIES_DIR: bin/static
SYSTEM_PROBE_BINARIES_DIR: bin/system-probe
USE_S3_CACHING: --omnibus-s3-cache
VCPKG_BLOB_SAS_URL: ci.datadog-agent-buildimages.vcpkg_blob_sas_url
WINDOWS_BUILDS_S3_BUCKET: $WIN_S3_BUCKET/builds
WINDOWS_POWERSHELL_DIR: $CI_PROJECT_DIR/signed_scripts
WINDOWS_TESTING_S3_BUCKET_A6: pipelines/A6/$CI_PIPELINE_ID
WINDOWS_TESTING_S3_BUCKET_A7: pipelines/A7/$CI_PIPELINE_ID
WINGET_PAT: ci.datadog-agent.winget_pat
WIN_S3_BUCKET: dd-agent-mstestingChanges Summary
ℹ️ Diff available in the job log. |
GustavoCaso
added
qa/done
|
Here are potential matches of the former version:
|
jeremy-hanna
approved these changes
Feb 11, 2025
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Static quality checks ✅Please find below the results from static quality gates Info
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: bf5a182 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.60 | [-0.29, +1.49] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.34 | [+0.19, +0.49] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.20 | [+0.14, +0.25] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.10 | [-0.75, +0.94] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.07 | [-3.01, +3.15] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.73, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.04 | [-0.42, +0.51] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.03 | [-0.79, +0.85] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.02] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.29, +0.26] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.79, +0.74] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.67, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.06 | [-0.97, +0.84] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.08 | [-0.12, -0.05] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.42 | [-0.48, -0.36] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -1.71 | [-2.50, -0.92] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
Devflow running:
|
maycmlee
approved these changes
Feb 11, 2025
CelianR
reviewed
Feb 12, 2025
CelianR
approved these changes
Feb 12, 2025
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
|
View all feedbacks in Devflow UI.
Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": context deadline exceeded DetailsIf you need support, contact us on Slack #devflow with those details! |
FlorentClarret
approved these changes
Feb 12, 2025
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
|
View all feedbacks in Devflow UI.
Started pipeline #55767143 |
github-actions
bot
added
medium review
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
|
View all feedbacks in Devflow UI.
Branch
Started pipeline #55770049 |
|
/merge |
|
View all feedbacks in Devflow UI.
The median merge time in
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Co-authored-by: jeremy-hanna <[email protected]> fa9884f
clarkb7
pushed a commit
that referenced
this pull request
Feb 13, 2025
Co-authored-by: jeremy-hanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the Go version to 1.23.6
Using the version image from this PR from the buildimages repo DataDog/datadog-agent-buildimages#754
Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes