Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usm] add regular and raw tracepoints /sched_process_exit #33943

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yuri-lipnesh
Copy link
Contributor

@yuri-lipnesh yuri-lipnesh commented Feb 11, 2025

What does this PR do?

Adds eBPF programs for tracepoint/sched/sched_process_exit (kernel < 4.17) and
raw_tracepoint/sched_process_exit (kernel>=4.17)
These programs clean terminated processes from ssl_read_args and ssl_read_ex_args maps.

Motivation

Significant amount of E2BIG errors was observed on staging clusters in January, 2025

This error spike aligns with mongodb pod restarts, which were triggered by Kubernetes due to health check failures.
The issue was reproduced on a local VM by stressing a simple SSL server with frequent connections. Terminating the server mid-operation led to stale entries accumulating in the relevant kernel maps.

Describe how you validated your changes

This code was tested on the staging cluster oddish-c, which frequently exhibited E2BIG errors for the ssl_read_args map. After deploying the fix, no errors occurred for 16 hours. See this metrics.

e2big_raw_tracepoint_fix

Passed CI unit tests and e2e tests.
USM load tests.

Possible Drawbacks / Trade-offs

The system-probe runs periodic sync job each 30 seconds to detect loaded SSL shared ibraries.
This job also additionally will clean possible stale entries in SSL-related kernel maps on kernel < 4.17

Additional Notes

@yuri-lipnesh yuri-lipnesh added changelog/no-changelog team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Feb 11, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 11, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Uncompressed package size comparison

Comparison with ancestor 48ffdc40f074f9b97884248e909ce419dfecf2a1

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.02MB ⚠️ 875.39MB 875.37MB 0.50MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 875.39MB 875.37MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 865.62MB 865.61MB 0.50MB
datadog-agent-arm64-deb 0.02MB ⚠️ 854.14MB 854.12MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 863.89MB 863.87MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.97MB 440.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.36MB 86.36MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.43MB 86.43MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.43MB 86.43MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.63MB 82.63MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.70MB 82.70MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55996333 --os-family=ubuntu

Note: This applies to commit 9fba5d2

Copy link

cit-pr-commenter bot commented Feb 11, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fb9c9c1e-5b94-4093-9f83-a1405c0070ee

Baseline: 48ffdc4
Comparison: 9fba5d2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.78 [+0.88, +2.69] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.38 [+0.31, +0.45] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.10 [-0.81, +1.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.72, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.81, +0.86] 1 Logs
quality_gate_idle_all_features memory utilization +0.00 [-0.06, +0.06] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.27] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.74, +0.69] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.94, +0.86] 1 Logs
file_tree memory utilization -0.04 [-0.12, +0.03] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.24 [-0.71, +0.24] 1 Logs
quality_gate_idle memory utilization -0.29 [-0.32, -0.25] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.33 [-3.40, +2.75] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.74 [-1.53, +0.06] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.27MiB 858.45MiB 202.89MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.68MiB 942.69MiB 308.65MiB 321.56MiB
static_quality_gate_docker_agent_arm64 934.06MiB 952.69MiB 292.64MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.76MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.73MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.04MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.73MiB 293.73MiB 102.1MiB 112.12MiB

@yuri-lipnesh yuri-lipnesh force-pushed the yuri.l/USMON-1411_ssl_read_exit branch from 1f1269f to 6cf2d27 Compare February 11, 2025 20:30
@yuri-lipnesh yuri-lipnesh force-pushed the yuri.l/USMON-1411_ssl_read_exit branch 2 times, most recently from 7eb24b6 to ef1ce42 Compare February 12, 2025 13:03
@yuri-lipnesh yuri-lipnesh force-pushed the yuri.l/USMON-1411_ssl_read_exit branch from ef1ce42 to 3832d0c Compare February 12, 2025 15:20
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant