Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] gpu: add event collector for debugging #33974

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Feb 12, 2025

What does this PR do?

This PR adds an event collector endpoint to the GPU monitoring module, which collects a set number of consumed events and returns them as JSON-lines data (one event JSON per line).

This endpoint can be queried using the following command line sudo curl --unix-socket $DD_SYSPROBE_SOCKET http://unix/gpu/debug/collect-events\?count\=N where N is the number of events to collect.

Motivation

Allow us to collect data from deployed scenarios for debugging and testing without having to replicate the entire monitored setup.

Describe how you validated your changes

Manually queried and checked the endpoint works multiple times and that parsing of data doesn't stop.

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 12, 2025
@gjulianm gjulianm marked this pull request as ready for review February 12, 2025 10:46
@gjulianm gjulianm requested a review from a team as a code owner February 12, 2025 10:46
@gjulianm gjulianm added the ask-review Ask required teams to review this PR label Feb 12, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 12, 2025

Uncompressed package size comparison

Comparison with ancestor fdf07f6789ea56338264d3023ffe8c6018417922

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.01MB ⚠️ 863.88MB 863.87MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 854.13MB 854.12MB 0.50MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 875.38MB 875.37MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 875.38MB 875.37MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 865.61MB 865.60MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.97MB 440.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.36MB 86.36MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.43MB 86.43MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.62MB 82.62MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.69MB 82.69MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Feb 12, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 800a3ccc-3f7c-47be-95a8-c6d638b62df4

Baseline: fdf07f6
Comparison: b84c859
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.68, +0.90] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.01, +0.06] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.96, +0.94] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.96, +0.93] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.30, +0.25] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.70, +0.61] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.97, +0.85] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.21 [-0.98, +0.56] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.34 [-0.80, +0.12] 1 Logs
file_tree memory utilization -0.61 [-0.67, -0.55] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.68 [-1.56, +0.21] 1 Logs
quality_gate_idle_all_features memory utilization -0.71 [-0.77, -0.64] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.86 [-0.94, -0.78] 1 Logs
quality_gate_logs % cpu utilization -1.94 [-4.98, +1.10] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@val06 val06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

cmd/system-probe/modules/gpu.go Show resolved Hide resolved
pkg/gpu/eventcollector.go Show resolved Hide resolved
pkg/gpu/eventcollector.go Show resolved Hide resolved
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55709276 --os-family=ubuntu

Note: This applies to commit b84c859

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.29MiB 858.45MiB 202.89MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.67MiB 942.69MiB 308.65MiB 321.56MiB
static_quality_gate_docker_agent_arm64 934.05MiB 952.69MiB 292.63MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.74MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.72MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.06MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.74MiB 293.73MiB 102.11MiB 112.12MiB

@gjulianm
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 12, 2025

View all feedbacks in Devflow UI.
2025-02-12 19:33:52 UTC ℹ️ Start processing command /merge


2025-02-12 19:33:55 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 32m.


2025-02-12 20:01:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit dea052c into main Feb 12, 2025
310 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guillermo.julian/record-events branch February 12, 2025 20:01
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants