Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[EBPF] gpu: introduce lazy ELF section reader (#33902)" #33995

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Feb 12, 2025

This reverts commit 7ca94a2.

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested a review from a team as a code owner February 12, 2025 19:50
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 12, 2025
@github-actions github-actions bot added the medium review PR review might take time label Feb 12, 2025
@chouetz chouetz merged commit 77aa534 into main Feb 12, 2025
104 of 149 checks passed
@chouetz chouetz deleted the nschweitzer/revert branch February 12, 2025 20:04
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 12, 2025
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a70cc9ba-e6b0-4fc8-bb2f-0381069ccffc

Baseline: 73a9deb
Comparison: 45bfa4d
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization -5.13 [-8.11, -2.15] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.59 [+0.50, +0.69] 1 Logs
file_tree memory utilization +0.23 [+0.18, +0.28] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.16 [-0.30, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.10 [-0.80, +1.00] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.78, +0.80] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.77, +0.78] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.28] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.75, +0.73] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.92, +0.88] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.07 [-0.98, +0.84] 1 Logs
quality_gate_idle memory utilization -0.26 [-0.30, -0.22] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.31 [-0.36, -0.26] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.05 [-1.95, -0.16] 1 Logs
quality_gate_logs % cpu utilization -5.13 [-8.11, -2.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant