Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add createEvent method and EventsApiCreateEventRequest type… #1977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adxdits
Copy link

@adxdits adxdits commented Dec 25, 2024

What does this PR do?

This PR introduces the createEvent method in the v2.EventsApi, along with the EventsApiCreateEventRequest type. The primary goal is to provide event creation functionality within the v2 API.

Key Changes:

  • Implemented createEvent method: This method allows users to create events within the EventsApi.ts file.
  • Defined EventsApiCreateEventRequest interface: The interface includes all required properties for event creation.
  • Exported the new method and interface: The method and type are exported via v2/index.ts.
  • Addresses Issue v2.EventsApi missing createEvent and EventsApiCreateEventRequest #1941: Resolves the missing functionality in the v2 API as outlined in the referenced issue.

Motivation

This feature is essential for enabling event creation in the v2 API, a critical component for our users. The implementation addresses a known gap in functionality, improving the API's overall usability and alignment with user expectations.

Related Issue: datadog-api-client-typescript#1941
This PR directly addresses the issue described above.

Additional Notes

  • All changes are backward-compatible and adhere to the existing API patterns.
  • The implementation includes adequate error handling and follows the project's coding standards.
  • Tests for the new functionality have been added, ensuring robustness and reliability.

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.
  • This PR does not rely on API client schema changes.
    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.
    • Note: CI shouldn't be run on this Draft PR, as it's expected to fail without the corresponding schema changes.

@adxdits adxdits requested a review from a team as a code owner December 25, 2024 23:39
Copy link

This PR has been automatically marked as stale because it has not had activity in the last 30 days.
If there is no activity for another 90 days, this issue will be automatically closed.

@github-actions github-actions bot added the stale label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant