Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling APM by default (#1006) #1011

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Dec 6, 2023

What does this PR do?

Breaking up #981 into 2 parts.

Motivation

Unblock Release of 1.3.0.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m added the enhancement New feature or request label Dec 6, 2023
@levan-m levan-m added this to the v1.3.0 milestone Dec 6, 2023
@levan-m levan-m requested review from a team as code owners December 6, 2023 18:06
@levan-m levan-m changed the base branch from main to v1.3 December 6, 2023 18:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Merging #1011 (7e7778b) into v1.3 (f364f53) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             v1.3    #1011      +/-   ##
==========================================
+ Coverage   57.13%   57.14%   +0.01%     
==========================================
  Files         164      164              
  Lines       19584    19589       +5     
==========================================
+ Hits        11190    11195       +5     
  Misses       7741     7741              
  Partials      653      653              
Flag Coverage Δ
unittests 57.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/datadoghq/v1alpha1/datadogagent_validation.go 0.00% <ø> (ø)
apis/datadoghq/v1alpha1/datadogmonitor_types.go 100.00% <ø> (ø)
...is/datadoghq/v1alpha1/datadogmonitor_validation.go 100.00% <ø> (ø)
apis/datadoghq/v1alpha1/datadogslo_types.go 100.00% <ø> (ø)
apis/datadoghq/v1alpha1/datadogslo_validation.go 100.00% <ø> (ø)
apis/datadoghq/v2alpha1/datadogagent_default.go 88.26% <100.00%> (+0.33%) ⬆️
apis/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)
cmd/kubectl-datadog/agent/check/check.go 9.22% <ø> (ø)
cmd/kubectl-datadog/agent/upgrade/upgrade.go 16.79% <ø> (ø)
...md/kubectl-datadog/clusteragent/upgrade/upgrade.go 7.93% <ø> (ø)
... and 24 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f364f53...7e7778b. Read the comment docs.

@levan-m levan-m force-pushed the levan-m/v1.3-cherry-pick-1006 branch from 0cdbe60 to 7e7778b Compare December 6, 2023 20:02
@levan-m levan-m force-pushed the levan-m/v1.3-cherry-pick-1006 branch from 7e7778b to 6defa3c Compare December 6, 2023 20:35
@levan-m levan-m merged commit 55f7d91 into v1.3 Dec 6, 2023
7 checks passed
@levan-m levan-m deleted the levan-m/v1.3-cherry-pick-1006 branch December 6, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants