-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gci correctly #1671
Enable gci correctly #1671
Conversation
I don't have permission to attach labels so could anybody help me attach appropriate labels to the PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 49.32% 49.32%
=======================================
Files 218 218
Lines 21171 21171
=======================================
Hits 10442 10442
Misses 10184 10184
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the change, just left one comment
43179e7
to
b53d805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
successfully built locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for container-platform files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for container-integrations files (only changes were import re-orders)
2ed4b33
to
a669d30
Compare
What does this PR do?
Even though the gci configuration exists in
.golangci.toml
, GCI itself has been disabled. I believe it would be better if we could enforce some rules on import statements and automatically lint and format them.Thanks for your review!
Motivation
Lint & sort the import statements automatically.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label