Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick pr linter when milestoned and demilestoned #1693

Closed
wants to merge 1 commit into from

Conversation

shuheiktgw
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 14, 2025 07:52
@shuheiktgw shuheiktgw modified the milestone: v1.14.0 Feb 14, 2025
@shuheiktgw shuheiktgw force-pushed the shuheiktgw/pr-linter-milestone branch from 545835b to 677728d Compare February 14, 2025 07:55
@shuheiktgw shuheiktgw modified the milestone: v1.14.0 Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (53c0d8c) to head (677728d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files         218      218           
  Lines       21244    21244           
=======================================
  Hits        10515    10515           
  Misses      10182    10182           
  Partials      547      547           
Flag Coverage Δ
unittests 49.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c0d8c...677728d. Read the comment docs.

@shuheiktgw shuheiktgw closed this Feb 14, 2025
@shuheiktgw shuheiktgw deleted the shuheiktgw/pr-linter-milestone branch February 14, 2025 08:10
@shuheiktgw
Copy link
Collaborator Author

I realized pull_request_target does not have milestoned and demilestoned...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants