Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code origin support to kafka message listeners #8301

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Add code origin support to kafka message listeners #8301

merged 4 commits into from
Feb 11, 2025

Conversation

evanchooly
Copy link
Contributor

@evanchooly evanchooly commented Jan 29, 2025 •
edited by jira bot
Loading

What Does This Do

Adds code origin information to client handlers for processing kafka events.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3157

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1739300679 1739301049
end_time 2025-02-11T19:05:56 2025-02-11T19:12:06
git_branch master evanchooly/DEBUG-3157
git_commit_sha f34e5f4 979e40c
start_time 2025-02-11T19:04:40 2025-02-11T19:10:50
See matching parameters
Baseline Candidate
ci_job_id 803672500 803672500
ci_pipeline_id 55579765 55579765
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1739300079 1739300079

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 9 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-58.034µs; +46.304µs] or [-20.376%; +16.257%]		 unstable
[-71.788µs; +59.855µs] or [-22.090%; +18.418%]		 unstable
[-82.329µs; +70.752µs] or [-24.191%; +20.789%]		 unstable
[-860.610µs; +548.589µs] or [-95.302%; +60.749%]		 unstable
[-130.970op/s; +131.100op/s] or [-5.042%; +5.047%]
scenario:basic same unstable
[-16222.754ns; +17655.229ns] or [-5.203%; +5.662%]		 unstable
[-91.752µs; +35.834µs] or [-26.074%; +10.183%]		 unstable
[-556.568µs; +132.989µs] or [-75.603%; +18.065%]		 unstable
[-223.931op/s; +223.981op/s] or [-8.957%; +8.959%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (324.976 µs) : 257, 393
.   : milestone, 325,
basic (311.815 µs) : 292, 331
.   : milestone, 312,
loop (10.142 ms) : 10096, 10188
.   : milestone, 10142,
section candidate
noprobe (319.01 µs) : 262, 376
.   : milestone, 319,
basic (312.531 µs) : 300, 325
.   : milestone, 313,
loop (10.143 ms) : 10101, 10185
.   : milestone, 10143,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 324.976 µs [257.073 µs, 392.88 µs]
basic 311.815 µs [292.231 µs, 331.399 µs]
loop 10.142 ms [10.096 ms, 10.188 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 319.01 µs [261.896 µs, 376.123 µs]
basic 312.531 µs [299.718 µs, 325.344 µs]
loop 10.143 ms [10.101 ms, 10.185 ms]

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3157
git_commit_date 1739207934 1739300079
git_commit_sha added74 979e40c
See matching parameters
Baseline Candidate
ci_job_date 1739301166 1739301166
ci_job_id 803672496 803672496
ci_pipeline_id 55579765 55579765
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce unsure
[-42689.575op/s; -4410.821op/s] or [-2.319%; -0.240%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3157
git_commit_date 1739296361 1739300079
git_commit_sha f34e5f4 979e40c
release_version 1.47.0-SNAPSHOT~f34e5f4b33 1.47.0-SNAPSHOT~979e40ccc9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739302550 1739302550
ci_job_id 803672489 803672489
ci_pipeline_id 55579765 55579765
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-wqj2avyw-project-304-concurrent-0-vgs7mfl2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-wqj2avyw-project-304-concurrent-0-vgs7mfl2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046823
Total [baseline] (8.673 s) : 0, 8673404
Agent [candidate] (1.048 s) : 0, 1048142
Total [candidate] (8.634 s) : 0, 8634128
section iast
Agent [baseline] (1.173 s) : 0, 1173470
Total [baseline] (9.267 s) : 0, 9267376
Agent [candidate] (1.176 s) : 0, 1176449
Total [candidate] (9.215 s) : 0, 9215065
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174706
Total [baseline] (9.22 s) : 0, 9219951
Agent [candidate] (1.176 s) : 0, 1176323
Total [candidate] (9.234 s) : 0, 9234268
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1178064
Total [baseline] (9.232 s) : 0, 9232310
Agent [candidate] (1.179 s) : 0, 1178713
Total [candidate] (9.239 s) : 0, 9238979
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.173 s 126.647 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 127.883 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.178 s 131.242 ms (12.5%)
Total tracing 8.673 s -
Total iast 9.267 s 593.972 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.22 s 546.547 ms (6.3%)
Total iast_TELEMETRY_OFF 9.232 s 558.905 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.176 s 128.307 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 128.181 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.179 s 130.572 ms (12.5%)
Total tracing 8.634 s -
Total iast 9.215 s 580.938 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.234 s 600.141 ms (7.0%)
Total iast_TELEMETRY_OFF 9.239 s 604.852 ms (7.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.374 ms) : 0, 718374
BytebuddyAgent [candidate] (720.437 ms) : 0, 720437
GlobalTracer [baseline] (244.224 ms) : 0, 244224
GlobalTracer [candidate] (243.619 ms) : 0, 243619
AppSec [baseline] (55.471 ms) : 0, 55471
AppSec [candidate] (55.175 ms) : 0, 55175
Remote Config [baseline] (715.815 µs) : 0, 716
Remote Config [candidate] (720.721 µs) : 0, 721
Telemetry [baseline] (12.868 ms) : 0, 12868
Telemetry [candidate] (12.886 ms) : 0, 12886
section iast
BytebuddyAgent [baseline] (834.891 ms) : 0, 834891
BytebuddyAgent [candidate] (836.742 ms) : 0, 836742
GlobalTracer [baseline] (234.17 ms) : 0, 234170
GlobalTracer [candidate] (234.964 ms) : 0, 234964
IAST [baseline] (22.846 ms) : 0, 22846
IAST [candidate] (22.809 ms) : 0, 22809
AppSec [baseline] (56.87 ms) : 0, 56870
AppSec [candidate] (57.371 ms) : 0, 57371
Remote Config [baseline] (626.31 µs) : 0, 626
Remote Config [candidate] (629.039 µs) : 0, 629
Telemetry [baseline] (8.829 ms) : 0, 8829
Telemetry [candidate] (8.68 ms) : 0, 8680
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.845 ms) : 0, 835845
BytebuddyAgent [candidate] (836.918 ms) : 0, 836918
GlobalTracer [baseline] (233.889 ms) : 0, 233889
GlobalTracer [candidate] (234.712 ms) : 0, 234712
IAST [baseline] (23.154 ms) : 0, 23154
IAST [candidate] (22.911 ms) : 0, 22911
AppSec [baseline] (57.287 ms) : 0, 57287
AppSec [candidate] (57.059 ms) : 0, 57059
Remote Config [baseline] (624.799 µs) : 0, 625
Remote Config [candidate] (620.15 µs) : 0, 620
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.74 ms) : 0, 8740
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.743 ms) : 0, 838743
BytebuddyAgent [candidate] (840.04 ms) : 0, 840040
GlobalTracer [baseline] (235.266 ms) : 0, 235266
GlobalTracer [candidate] (234.498 ms) : 0, 234498
IAST [baseline] (26.422 ms) : 0, 26422
IAST [candidate] (25.513 ms) : 0, 25513
AppSec [baseline] (53.089 ms) : 0, 53089
AppSec [candidate] (54.053 ms) : 0, 54053
Remote Config [baseline] (617.025 µs) : 0, 617
Remote Config [candidate] (610.465 µs) : 0, 610
Telemetry [baseline] (8.704 ms) : 0, 8704
Telemetry [candidate] (8.653 ms) : 0, 8653
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047135
Total [baseline] (10.453 s) : 0, 10452812
Agent [candidate] (1.047 s) : 0, 1047295
Total [candidate] (10.418 s) : 0, 10418334
section appsec
Agent [baseline] (1.189 s) : 0, 1188761
Total [baseline] (10.751 s) : 0, 10751010
Agent [candidate] (1.198 s) : 0, 1197812
Total [candidate] (10.806 s) : 0, 10805922
section iast
Agent [baseline] (1.185 s) : 0, 1184611
Total [baseline] (10.965 s) : 0, 10964833
Agent [candidate] (1.174 s) : 0, 1173886
Total [candidate] (10.926 s) : 0, 10925779
section profiling
Agent [baseline] (1.279 s) : 0, 1279164
Total [baseline] (10.91 s) : 0, 10909930
Agent [candidate] (1.266 s) : 0, 1265526
Total [candidate] (10.888 s) : 0, 10887520
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.189 s 141.626 ms (13.5%)
Agent iast 1.185 s 137.476 ms (13.1%)
Agent profiling 1.279 s 232.03 ms (22.2%)
Total tracing 10.453 s -
Total appsec 10.751 s 298.198 ms (2.9%)
Total iast 10.965 s 512.021 ms (4.9%)
Total profiling 10.91 s 457.118 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.198 s 150.517 ms (14.4%)
Agent iast 1.174 s 126.592 ms (12.1%)
Agent profiling 1.266 s 218.232 ms (20.8%)
Total tracing 10.418 s -
Total appsec 10.806 s 387.588 ms (3.7%)
Total iast 10.926 s 507.445 ms (4.9%)
Total profiling 10.888 s 469.186 ms (4.5%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.417 ms) : 0, 717417
BytebuddyAgent [candidate] (718.809 ms) : 0, 718809
GlobalTracer [baseline] (243.928 ms) : 0, 243928
GlobalTracer [candidate] (243.783 ms) : 0, 243783
AppSec [baseline] (55.292 ms) : 0, 55292
AppSec [candidate] (55.02 ms) : 0, 55020
Remote Config [baseline] (721.527 µs) : 0, 722
Remote Config [candidate] (711.224 µs) : 0, 711
Telemetry [baseline] (14.476 ms) : 0, 14476
Telemetry [candidate] (13.703 ms) : 0, 13703
section appsec
BytebuddyAgent [baseline] (736.573 ms) : 0, 736573
BytebuddyAgent [candidate] (741.434 ms) : 0, 741434
GlobalTracer [baseline] (241.123 ms) : 0, 241123
GlobalTracer [candidate] (243.147 ms) : 0, 243147
AppSec [baseline] (175.845 ms) : 0, 175845
AppSec [candidate] (177.69 ms) : 0, 177690
Remote Config [baseline] (660.472 µs) : 0, 660
Remote Config [candidate] (672.35 µs) : 0, 672
Telemetry [baseline] (8.315 ms) : 0, 8315
Telemetry [candidate] (8.354 ms) : 0, 8354
IAST [baseline] (21.873 ms) : 0, 21873
IAST [candidate] (22.364 ms) : 0, 22364
section iast
BytebuddyAgent [baseline] (843.821 ms) : 0, 843821
BytebuddyAgent [candidate] (835.479 ms) : 0, 835479
GlobalTracer [baseline] (235.658 ms) : 0, 235658
GlobalTracer [candidate] (233.819 ms) : 0, 233819
AppSec [baseline] (57.283 ms) : 0, 57283
AppSec [candidate] (57.061 ms) : 0, 57061
Remote Config [baseline] (636.158 µs) : 0, 636
Remote Config [candidate] (617.655 µs) : 0, 618
Telemetry [baseline] (8.795 ms) : 0, 8795
Telemetry [candidate] (8.747 ms) : 0, 8747
IAST [baseline] (23.128 ms) : 0, 23128
IAST [candidate] (22.971 ms) : 0, 22971
section profiling
ProfilingAgent [baseline] (97.444 ms) : 0, 97444
ProfilingAgent [candidate] (95.718 ms) : 0, 95718
BytebuddyAgent [baseline] (715.917 ms) : 0, 715917
BytebuddyAgent [candidate] (708.699 ms) : 0, 708699
GlobalTracer [baseline] (357.136 ms) : 0, 357136
GlobalTracer [candidate] (354.667 ms) : 0, 354667
AppSec [baseline] (56.006 ms) : 0, 56006
AppSec [candidate] (54.551 ms) : 0, 54551
Remote Config [baseline] (717.62 µs) : 0, 718
Remote Config [candidate] (716.867 µs) : 0, 717
Telemetry [baseline] (9.087 ms) : 0, 9087
Telemetry [candidate] (8.893 ms) : 0, 8893
Profiling [baseline] (97.473 ms) : 0, 97473
Profiling [candidate] (95.745 ms) : 0, 95745
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-11T19:05:46 2025-02-11T19:12:51
git_branch master evanchooly/DEBUG-3157
git_commit_date 1739296361 1739300079
git_commit_sha f34e5f4 979e40c
release_version 1.47.0-SNAPSHOT~f34e5f4b33 1.47.0-SNAPSHOT~979e40ccc9
start_time 2025-02-11T19:05:32 2025-02-11T19:12:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739301530 1739301530
ci_job_id 803672490 803672490
ci_pipeline_id 55579765 55579765
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-wqj2avyw-project-304-concurrent-1-5lp065nd 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-wqj2avyw-project-304-concurrent-1-5lp065nd 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-85.782µs; -34.551µs] or [-5.485%; -2.209%]		 unstable
[-448.490op/s; +676.410op/s] or [-15.137%; +22.829%]		 1.504ms 3076.923op/s 1.564ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.744 ms) : 1721, 1768
.   : milestone, 1744,
appsec_no_iast (1.751 ms) : 1726, 1776
.   : milestone, 1751,
iast (1.52 ms) : 1495, 1544
.   : milestone, 1520,
profiling (1.564 ms) : 1539, 1589
.   : milestone, 1564,
tracing (1.503 ms) : 1479, 1527
.   : milestone, 1503,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.767 ms) : 1744, 1791
.   : milestone, 1767,
appsec_no_iast (1.748 ms) : 1723, 1773
.   : milestone, 1748,
iast (1.518 ms) : 1494, 1543
.   : milestone, 1518,
profiling (1.504 ms) : 1481, 1526
.   : milestone, 1504,
tracing (1.501 ms) : 1476, 1525
.   : milestone, 1501,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.374 ms] -
appsec 1.744 ms [1.721 ms, 1.768 ms] 389.679 µs (28.8%)
appsec_no_iast 1.751 ms [1.726 ms, 1.776 ms] 396.901 µs (29.3%)
iast 1.52 ms [1.495 ms, 1.544 ms] 165.503 µs (12.2%)
profiling 1.564 ms [1.539 ms, 1.589 ms] 209.424 µs (15.5%)
tracing 1.503 ms [1.479 ms, 1.527 ms] 148.836 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.767 ms [1.744 ms, 1.791 ms] 405.109 µs (29.7%)
appsec_no_iast 1.748 ms [1.723 ms, 1.773 ms] 385.932 µs (28.3%)
iast 1.518 ms [1.494 ms, 1.543 ms] 155.959 µs (11.4%)
profiling 1.504 ms [1.481 ms, 1.526 ms] 141.497 µs (10.4%)
tracing 1.501 ms [1.476 ms, 1.525 ms] 138.395 µs (10.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.117 µs) : 364, 405
.   : milestone, 384,
iast (505.536 µs) : 484, 527
.   : milestone, 506,
iast_FULL (743.854 µs) : 722, 766
.   : milestone, 744,
iast_GLOBAL (557.835 µs) : 535, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (511.548 µs) : 490, 533
.   : milestone, 512,
iast_INACTIVE (461.88 µs) : 440, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (494.21 µs) : 472, 517
.   : milestone, 494,
tracing (450.983 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (376.937 µs) : 357, 397
.   : milestone, 377,
iast (516.788 µs) : 494, 539
.   : milestone, 517,
iast_FULL (742.059 µs) : 720, 764
.   : milestone, 742,
iast_GLOBAL (555.585 µs) : 534, 577
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (508.282 µs) : 487, 530
.   : milestone, 508,
iast_INACTIVE (465.748 µs) : 444, 487
.   : milestone, 466,
iast_TELEMETRY_OFF (500.126 µs) : 477, 523
.   : milestone, 500,
tracing (455.49 µs) : 435, 476
.   : milestone, 455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.117 µs [363.721 µs, 404.513 µs] -
iast 505.536 µs [484.008 µs, 527.065 µs] 121.419 µs (31.6%)
iast_FULL 743.854 µs [721.889 µs, 765.819 µs] 359.737 µs (93.7%)
iast_GLOBAL 557.835 µs [534.909 µs, 580.762 µs] 173.719 µs (45.2%)
iast_HARDCODED_SECRET_DISABLED 511.548 µs [489.636 µs, 533.46 µs] 127.431 µs (33.2%)
iast_INACTIVE 461.88 µs [440.358 µs, 483.401 µs] 77.763 µs (20.2%)
iast_TELEMETRY_OFF 494.21 µs [471.618 µs, 516.803 µs] 110.093 µs (28.7%)
tracing 450.983 µs [430.355 µs, 471.612 µs] 66.867 µs (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.937 µs [357.109 µs, 396.766 µs] -
iast 516.788 µs [494.433 µs, 539.143 µs] 139.851 µs (37.1%)
iast_FULL 742.059 µs [719.994 µs, 764.124 µs] 365.122 µs (96.9%)
iast_GLOBAL 555.585 µs [533.794 µs, 577.376 µs] 178.648 µs (47.4%)
iast_HARDCODED_SECRET_DISABLED 508.282 µs [486.835 µs, 529.73 µs] 131.345 µs (34.8%)
iast_INACTIVE 465.748 µs [444.192 µs, 487.303 µs] 88.81 µs (23.6%)
iast_TELEMETRY_OFF 500.126 µs [476.868 µs, 523.384 µs] 123.189 µs (32.7%)
tracing 455.49 µs [434.692 µs, 476.288 µs] 78.553 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3157
git_commit_date 1739296361 1739300079
git_commit_sha f34e5f4 979e40c
release_version 1.47.0-SNAPSHOT~f34e5f4b33 1.47.0-SNAPSHOT~979e40ccc9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1739301961 1739301961
ci_job_id 803672493 803672493
ci_pipeline_id 55579765 55579765
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-wqj2avyw-project-304-concurrent-2-pj7ds7ww 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-wqj2avyw-project-304-concurrent-2-pj7ds7ww 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.651 s) : 15651000, 15651000
.   : milestone, 15651000,
appsec (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
iast (18.983 s) : 18983000, 18983000
.   : milestone, 18983000,
iast_GLOBAL (17.89 s) : 17890000, 17890000
.   : milestone, 17890000,
profiling (15.083 s) : 15083000, 15083000
.   : milestone, 15083000,
tracing (14.878 s) : 14878000, 14878000
.   : milestone, 14878000,
section candidate
no_agent (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
appsec (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
iast (18.748 s) : 18748000, 18748000
.   : milestone, 18748000,
iast_GLOBAL (18.232 s) : 18232000, 18232000
.   : milestone, 18232000,
profiling (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
tracing (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.651 s [15.651 s, 15.651 s] -
appsec 14.958 s [14.958 s, 14.958 s] -693.0 ms (-4.4%)
iast 18.983 s [18.983 s, 18.983 s] 3.332 s (21.3%)
iast_GLOBAL 17.89 s [17.89 s, 17.89 s] 2.239 s (14.3%)
profiling 15.083 s [15.083 s, 15.083 s] -568.0 ms (-3.6%)
tracing 14.878 s [14.878 s, 14.878 s] -773.0 ms (-4.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.86 s [14.86 s, 14.86 s] -
appsec 14.988 s [14.988 s, 14.988 s] 128.0 ms (0.9%)
iast 18.748 s [18.748 s, 18.748 s] 3.888 s (26.2%)
iast_GLOBAL 18.232 s [18.232 s, 18.232 s] 3.372 s (22.7%)
profiling 14.988 s [14.988 s, 14.988 s] 128.0 ms (0.9%)
tracing 14.889 s [14.889 s, 14.889 s] 29.0 ms (0.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~979e40ccc9, baseline=1.47.0-SNAPSHOT~f34e5f4b33
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.373 ms) : 2329, 2416
.   : milestone, 2373,
iast (2.125 ms) : 2070, 2180
.   : milestone, 2125,
iast_GLOBAL (2.163 ms) : 2107, 2218
.   : milestone, 2163,
profiling (1.971 ms) : 1928, 2015
.   : milestone, 1971,
tracing (1.95 ms) : 1908, 1992
.   : milestone, 1950,
section candidate
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.375 ms) : 2332, 2418
.   : milestone, 2375,
iast (2.126 ms) : 2070, 2181
.   : milestone, 2126,
iast_GLOBAL (2.172 ms) : 2116, 2228
.   : milestone, 2172,
profiling (1.991 ms) : 1946, 2036
.   : milestone, 1991,
tracing (1.958 ms) : 1915, 2000
.   : milestone, 1958,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.373 ms [2.329 ms, 2.416 ms] 896.233 µs (60.7%)
iast 2.125 ms [2.07 ms, 2.18 ms] 648.729 µs (43.9%)
iast_GLOBAL 2.163 ms [2.107 ms, 2.218 ms] 686.458 µs (46.5%)
profiling 1.971 ms [1.928 ms, 2.015 ms] 494.818 µs (33.5%)
tracing 1.95 ms [1.908 ms, 1.992 ms] 473.653 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.375 ms [2.332 ms, 2.418 ms] 898.157 µs (60.8%)
iast 2.126 ms [2.07 ms, 2.181 ms] 648.913 µs (43.9%)
iast_GLOBAL 2.172 ms [2.116 ms, 2.228 ms] 694.979 µs (47.1%)
profiling 1.991 ms [1.946 ms, 2.036 ms] 513.981 µs (34.8%)
tracing 1.958 ms [1.915 ms, 2.0 ms] 480.904 µs (32.6%)

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3157
git_commit_date 1739207934 1739300079
git_commit_sha added74 979e40c
See matching parameters
Baseline Candidate
ci_job_date 1739301222 1739301222
ci_job_id 803672498 803672498
ci_pipeline_id 55579765 55579765
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@evanchooly evanchooly force-pushed the evanchooly/DEBUG-3157 branch from ab26d6f to 79df06c Compare February 10, 2025 19:15
@evanchooly evanchooly added comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation labels Feb 10, 2025
@evanchooly evanchooly marked this pull request as ready for review February 10, 2025 20:24
@evanchooly evanchooly requested review from a team as code owners February 10, 2025 20:24
@evanchooly evanchooly requested review from jpbempel and nayeem-kamal and removed request for a team February 10, 2025 20:24
@evanchooly evanchooly force-pushed the evanchooly/DEBUG-3157 branch from 28f550d to 92505f7 Compare February 10, 2025 20:35
@evanchooly
add code origin support to kafka client
0eddcc4 
# Conflicts:
#	dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/CodeOriginProbe.java
@evanchooly evanchooly force-pushed the evanchooly/DEBUG-3157 branch from 92505f7 to 0eddcc4 Compare February 10, 2025 20:38
@evanchooly
remove duplicate(?) dep from main_java17Implementation
ea365d3 
update constant renames from rebase
@evanchooly evanchooly changed the title wip Add code origin support to kafka message listeners Feb 10, 2025
evanchooly
evanchooly commented Feb 11, 2025
View reviewed changes
.../main/java/datadog/trace/instrumentation/kafka_clients38/MessageListenerInstrumentation.java

@Override
public boolean isEnabled() {
return InstrumenterConfig.get().isCodeOriginEnabled() && super.isEnabled();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbempel I added this extra check after remembering the other CO advices do this check here to short circuit out in the cases where CO is not enabled.

@evanchooly evanchooly merged commit 3e097b6 into master Feb 11, 2025
209 checks passed
@evanchooly evanchooly deleted the evanchooly/DEBUG-3157 branch February 11, 2025 22:00
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation type: enhancement
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@evanchooly @jpbempel