-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for endpoint discovery in spring mvc #8352
Draft
manuel-alvarez-alvarez
wants to merge
1
commit into
master
Choose a base branch
from
malvarez/waf-endpoint-discovery-spring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add support for endpoint discovery in spring mvc #8352
manuel-alvarez-alvarez
wants to merge
1
commit into
master
from
malvarez/waf-endpoint-discovery-spring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
added
comp: asm waf
Application Security Management (WAF)
inst: spring
Spring instrumentation
type: enhancement
labels
Feb 7, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044246
Total [baseline] (8.681 s) : 0, 8680862
Agent [candidate] (1.049 s) : 0, 1049428
Total [candidate] (8.639 s) : 0, 8638754
section iast
Agent [baseline] (1.173 s) : 0, 1172575
Total [baseline] (9.23 s) : 0, 9230089
Agent [candidate] (1.174 s) : 0, 1174030
Total [candidate] (9.249 s) : 0, 9249335
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170916
Total [baseline] (9.201 s) : 0, 9200585
Agent [candidate] (1.177 s) : 0, 1177118
Total [candidate] (9.206 s) : 0, 9206394
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169189
Total [baseline] (9.205 s) : 0, 9205210
Agent [candidate] (1.18 s) : 0, 1179748
Total [candidate] (9.235 s) : 0, 9235178
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.454 ms) : 0, 717454
BytebuddyAgent [candidate] (722.7 ms) : 0, 722700
GlobalTracer [baseline] (242.894 ms) : 0, 242894
GlobalTracer [candidate] (243.846 ms) : 0, 243846
AppSec [baseline] (55.011 ms) : 0, 55011
AppSec [candidate] (55.496 ms) : 0, 55496
Remote Config [baseline] (703.556 µs) : 0, 704
Remote Config [candidate] (736.037 µs) : 0, 736
Telemetry [baseline] (12.976 ms) : 0, 12976
Telemetry [candidate] (11.389 ms) : 0, 11389
section iast
BytebuddyAgent [baseline] (834.966 ms) : 0, 834966
BytebuddyAgent [candidate] (835.93 ms) : 0, 835930
GlobalTracer [baseline] (233.18 ms) : 0, 233180
GlobalTracer [candidate] (233.312 ms) : 0, 233312
AppSec [baseline] (57.03 ms) : 0, 57030
AppSec [candidate] (57.41 ms) : 0, 57410
Remote Config [baseline] (620.702 µs) : 0, 621
Remote Config [candidate] (611.98 µs) : 0, 612
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.746 ms) : 0, 8746
IAST [baseline] (22.808 ms) : 0, 22808
IAST [candidate] (22.843 ms) : 0, 22843
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.569 ms) : 0, 833569
BytebuddyAgent [candidate] (839.622 ms) : 0, 839622
GlobalTracer [baseline] (233.452 ms) : 0, 233452
GlobalTracer [candidate] (233.064 ms) : 0, 233064
AppSec [baseline] (56.535 ms) : 0, 56535
AppSec [candidate] (57.034 ms) : 0, 57034
Remote Config [baseline] (618.618 µs) : 0, 619
Remote Config [candidate] (606.218 µs) : 0, 606
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.71 ms) : 0, 8710
IAST [baseline] (22.79 ms) : 0, 22790
IAST [candidate] (22.656 ms) : 0, 22656
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.012 ms) : 0, 832012
BytebuddyAgent [candidate] (839.617 ms) : 0, 839617
GlobalTracer [baseline] (233.224 ms) : 0, 233224
GlobalTracer [candidate] (235.238 ms) : 0, 235238
AppSec [baseline] (55.567 ms) : 0, 55567
AppSec [candidate] (55.343 ms) : 0, 55343
Remote Config [baseline] (618.245 µs) : 0, 618
Remote Config [candidate] (602.673 µs) : 0, 603
Telemetry [baseline] (8.615 ms) : 0, 8615
Telemetry [candidate] (8.757 ms) : 0, 8757
IAST [baseline] (23.937 ms) : 0, 23937
IAST [candidate] (24.888 ms) : 0, 24888
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043579
Total [baseline] (10.468 s) : 0, 10467552
Agent [candidate] (1.048 s) : 0, 1047525
Total [candidate] (10.6 s) : 0, 10599647
section appsec
Agent [baseline] (1.192 s) : 0, 1192039
Total [baseline] (10.73 s) : 0, 10730108
Agent [candidate] (1.191 s) : 0, 1191445
Total [candidate] (10.76 s) : 0, 10760110
section iast
Agent [baseline] (1.174 s) : 0, 1173903
Total [baseline] (10.943 s) : 0, 10942797
Agent [candidate] (1.173 s) : 0, 1172634
Total [candidate] (11.072 s) : 0, 11071808
section profiling
Agent [baseline] (1.28 s) : 0, 1280117
Total [baseline] (10.823 s) : 0, 10822807
Agent [candidate] (1.263 s) : 0, 1263060
Total [candidate] (10.899 s) : 0, 10899383
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.363 ms) : 0, 717363
BytebuddyAgent [candidate] (717.277 ms) : 0, 717277
GlobalTracer [baseline] (243.398 ms) : 0, 243398
GlobalTracer [candidate] (243.368 ms) : 0, 243368
AppSec [baseline] (55.455 ms) : 0, 55455
AppSec [candidate] (55.872 ms) : 0, 55872
Remote Config [baseline] (710.226 µs) : 0, 710
Remote Config [candidate] (743.308 µs) : 0, 743
Telemetry [baseline] (11.417 ms) : 0, 11417
Telemetry [candidate] (15.095 ms) : 0, 15095
section appsec
BytebuddyAgent [baseline] (738.168 ms) : 0, 738168
BytebuddyAgent [candidate] (736.873 ms) : 0, 736873
GlobalTracer [baseline] (241.636 ms) : 0, 241636
GlobalTracer [candidate] (241.495 ms) : 0, 241495
AppSec [baseline] (177.031 ms) : 0, 177031
AppSec [candidate] (176.983 ms) : 0, 176983
Remote Config [baseline] (662.186 µs) : 0, 662
Remote Config [candidate] (674.876 µs) : 0, 675
Telemetry [baseline] (8.31 ms) : 0, 8310
Telemetry [candidate] (9.052 ms) : 0, 9052
IAST [baseline] (21.964 ms) : 0, 21964
IAST [candidate] (22.145 ms) : 0, 22145
section iast
BytebuddyAgent [baseline] (835.765 ms) : 0, 835765
BytebuddyAgent [candidate] (834.557 ms) : 0, 834557
GlobalTracer [baseline] (233.797 ms) : 0, 233797
GlobalTracer [candidate] (233.321 ms) : 0, 233321
AppSec [baseline] (56.948 ms) : 0, 56948
AppSec [candidate] (57.425 ms) : 0, 57425
Remote Config [baseline] (620.516 µs) : 0, 621
Remote Config [candidate] (605.305 µs) : 0, 605
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.62 ms) : 0, 8620
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.812 ms) : 0, 22812
section profiling
BytebuddyAgent [baseline] (716.528 ms) : 0, 716528
BytebuddyAgent [candidate] (706.64 ms) : 0, 706640
GlobalTracer [baseline] (357.497 ms) : 0, 357497
GlobalTracer [candidate] (353.856 ms) : 0, 353856
AppSec [baseline] (56.157 ms) : 0, 56157
AppSec [candidate] (55.325 ms) : 0, 55325
Remote Config [baseline] (708.795 µs) : 0, 709
Remote Config [candidate] (648.102 µs) : 0, 648
Telemetry [baseline] (9.035 ms) : 0, 9035
Telemetry [candidate] (8.871 ms) : 0, 8871
ProfilingAgent [baseline] (97.556 ms) : 0, 97556
ProfilingAgent [candidate] (95.496 ms) : 0, 95496
Profiling [baseline] (97.58 ms) : 0, 97580
Profiling [candidate] (95.52 ms) : 0, 95520
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (386.681 µs) : 366, 407
. : milestone, 387,
iast (507.325 µs) : 486, 529
. : milestone, 507,
iast_FULL (742.86 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (547.727 µs) : 526, 569
. : milestone, 548,
iast_HARDCODED_SECRET_DISABLED (504.706 µs) : 483, 526
. : milestone, 505,
iast_INACTIVE (455.227 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (491.754 µs) : 469, 514
. : milestone, 492,
tracing (452.891 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (377.078 µs) : 357, 397
. : milestone, 377,
iast (514.62 µs) : 492, 538
. : milestone, 515,
iast_FULL (736.595 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (561.783 µs) : 539, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (512.287 µs) : 490, 534
. : milestone, 512,
iast_INACTIVE (463.194 µs) : 442, 485
. : milestone, 463,
iast_TELEMETRY_OFF (495.393 µs) : 472, 518
. : milestone, 495,
tracing (455.855 µs) : 434, 478
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (1.373 ms) : 1354, 1393
. : milestone, 1373,
appsec (1.756 ms) : 1732, 1779
. : milestone, 1756,
appsec_no_iast (1.759 ms) : 1734, 1784
. : milestone, 1759,
iast (1.483 ms) : 1458, 1509
. : milestone, 1483,
profiling (1.547 ms) : 1523, 1571
. : milestone, 1547,
tracing (1.513 ms) : 1488, 1539
. : milestone, 1513,
section candidate
no_agent (1.359 ms) : 1339, 1379
. : milestone, 1359,
appsec (1.765 ms) : 1742, 1789
. : milestone, 1765,
appsec_no_iast (1.759 ms) : 1734, 1784
. : milestone, 1759,
iast (1.502 ms) : 1477, 1527
. : milestone, 1502,
profiling (1.503 ms) : 1480, 1526
. : milestone, 1503,
tracing (1.494 ms) : 1470, 1518
. : milestone, 1494,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (14.701 s) : 14701000, 14701000
. : milestone, 14701000,
appsec (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
iast (19.041 s) : 19041000, 19041000
. : milestone, 19041000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
profiling (15.091 s) : 15091000, 15091000
. : milestone, 15091000,
tracing (15.131 s) : 15131000, 15131000
. : milestone, 15131000,
section candidate
no_agent (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
appsec (15.172 s) : 15172000, 15172000
. : milestone, 15172000,
iast (18.328 s) : 18328000, 18328000
. : milestone, 18328000,
iast_GLOBAL (17.615 s) : 17615000, 17615000
. : milestone, 17615000,
profiling (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
tracing (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~e92e23345d, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.37 ms) : 2327, 2413
. : milestone, 2370,
iast (2.113 ms) : 2058, 2167
. : milestone, 2113,
iast_GLOBAL (2.157 ms) : 2101, 2212
. : milestone, 2157,
profiling (1.985 ms) : 1940, 2030
. : milestone, 1985,
tracing (1.947 ms) : 1905, 1989
. : milestone, 1947,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.366 ms) : 2323, 2410
. : milestone, 2366,
iast (2.116 ms) : 2061, 2171
. : milestone, 2116,
iast_GLOBAL (2.161 ms) : 2106, 2217
. : milestone, 2161,
profiling (1.978 ms) : 1934, 2021
. : milestone, 1978,
tracing (1.944 ms) : 1902, 1986
. : milestone, 1944,
|
manuel-alvarez-alvarez
force-pushed
the
malvarez/waf-endpoint-discovery-spring
branch
from
February 7, 2025 10:06
f1ad95d
to
e92e233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
inst: spring
Spring instrumentation
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-56437