fix(config): keep the lookup value as passed #4901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was transforming the lookup parameter to a string. Closes DataDog#4894
|
Thank you for the contribution. I've shared this PR to the relevant people, hopefully it'll get some attention! |
|
It doesn't seem to have any appetite to merge it because the v4 branch is too old. I'm closing this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4901 +/- ##
==========================================
+ Coverage 80.85% 81.09% +0.23%
==========================================
Files 474 480 +6
Lines 21165 21438 +273
==========================================
+ Hits 17114 17386 +272
- Misses 4051 4052 +1 ☔ View full report in Codecov by Sentry. |
6 tasks
|
Remaking this PR in #5244 so CI runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was transforming the lookup
parameter to a string.
What does this PR do?
Prevent the erroneous transformation of
lookupparameter into a string. It must be kept as a functionMotivation
The bug described in #4894 : nodejs throws an error if
lookupis transformed into a stringCloses #4894