Skip to content

Commit

Permalink
chore(profiling): set libdd_required when timeline_enabled (#10182)
Browse files Browse the repository at this point in the history
Manual backport of #10182

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 56f907a)
  • Loading branch information
taegyunkim committed Aug 12, 2024
1 parent 337a2d5 commit e30cf2a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ddtrace/settings/profiling.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def _check_for_stack_v2_available():
# We don't check for the availability of the ddup module when determining whether libdd is _required_,
# since it's up to the application code to determine what happens in that failure case.
def _is_libdd_required(config):
return config.stack.v2.enabled or config._libdd_required
return config.stack.v2.enabled or config._libdd_required or config.timeline_enabled


class ProfilingConfig(En):
Expand Down

0 comments on commit e30cf2a

Please sign in to comment.