fix(profiling): show lock init location and hide internal frame (#9692) [backport-2.10] #10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<img width="595" alt="Screenshot 2024-07-01 at 9 32 45 PM" src="https://github.com/DataDog/dd-trace-py/assets/6655247/aa7cf96e-db56-4771-9517-b0fcdd8ccc0f"> - Lock Name shows the line number of where `acquire/release/__enter__/__exit__` was called, which is duplicated in the Call Stack - Call Stack shows a frame for Profiler internal function, [\_\_enter\_\_](https://github.com/DataDog/dd-trace-py/blob/42ccea9b13e232bcce4a1d20b9d11eda7904226d/ddtrace/profiling/collector/_lock.py#L235) <img width="600" alt="Screenshot 2024-07-01 at 9 27 35 PM" src="https://github.com/DataDog/dd-trace-py/assets/6655247/2c360183-c25f-4ea2-963f-c4df1453225d"> - Lock Name shows the line number where the lock was initialized. - Call Stack shows user codes only. This actually reverts some of the changes I made in #9615, but I believe this PR makes everything clearer. - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 97969ee)
taegyunkim
changed the title
Datadog ReportBranch report: ✅ 0 Failed, 573 Passed, 525 Skipped, 51m 30.52s Total duration (32m 11.82s time saved) |
sanchda
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #9692 to 2.10
acquire/release/__enter__/__exit__was called, which is duplicated in the Call StackThis actually reverts some of the changes I made in #9615, but I believe this PR makes everything clearer.
Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist
policy
(cherry picked from commit 97969ee)