Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry): support attribute argument in TracerProvider.get_tracer() [backport #9941 to 2.8] #10083

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Aug 5, 2024

Backports #9941

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners August 5, 2024 17:09
@mabdinur mabdinur requested review from emmettbutler and quinna-h and removed request for a team August 5, 2024 17:09
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 5, 2024

Datadog Report

Branch report: munir/backport-9974-to-2-8
Commit report: 8bb3562
Test service: dd-trace-py

✅ 0 Failed, 170911 Passed, 1565 Skipped, 12h 42m 46.13s Total duration (31m 47.54s time saved)
❄️ 1 New Flaky
⌛ 10 Performance Regressions

New Flaky Tests (1)

  • test_span_schematization[None-None] - test_graphql.py - Last Failure

    Expand for error
     sent 629B in 1.06349s to http://localhost:9126/v0.5/traces
       
     assert b'sent 629B i...v0.5/traces\n' == b''
       Use -v to get more diff
    

⌛ Performance Regressions vs Default Branch (10)

This report shows up to 5 performance regressions.

  • test_partial_flush_too_many - test_tracer.py 3.41s (+2.74s, +408%) - Details
  • test_schematized_service_name[v1-mysvc] - test_request.py 5.25s (+4.33s, +473%) - Details
  • test_schematized_service_name[None-None] - test_request.py 7.26s (+6.34s, +691%)
  • test_unspecified_service_v1 - test_elasticsearch.py 3.98s (+3.3s, +487%)
  • test_extract_128bit_trace_ids_datadog - test_propagation.py 3.33s (+2.71s, +435%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Aug 5, 2024

Benchmarks

Benchmark execution time: 2024-08-05 23:36:07

Comparing candidate commit 8bb3562 in PR branch munir/backport-9974-to-2-8 with baseline commit d6a3581 in branch 2.8.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 185 metrics, 9 unstable metrics.

Base automatically changed from munir/backport-9929-to-2-8 to 2.8 August 5, 2024 22:18
@mabdinur mabdinur requested a review from a team as a code owner August 5, 2024 22:18
@mabdinur mabdinur force-pushed the munir/backport-9974-to-2-8 branch from 85e6e72 to c8c5057 Compare August 5, 2024 22:31
@mabdinur mabdinur force-pushed the munir/backport-9974-to-2-8 branch from c8c5057 to 8bb3562 Compare August 5, 2024 22:33
@mabdinur mabdinur enabled auto-merge (squash) August 5, 2024 22:33
@mabdinur mabdinur disabled auto-merge August 6, 2024 15:09
@mabdinur mabdinur merged commit 3de8627 into 2.8 Aug 6, 2024
145 of 165 checks passed
@mabdinur mabdinur deleted the munir/backport-9974-to-2-8 branch August 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants