Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs/ to apm-python code ownership [backport 2.10] #10091

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Aug 5, 2024

Manual backport of #10041

  • PR author has checked that all the criteria below are met

  • The PR description includes an overview of the change

  • The PR description articulates the motivation for the change

  • The change includes tests OR the PR description describes a testing strategy

  • The PR description notes risks associated with the change, if any

  • Newly-added code is easy to change

  • The change follows the library release note guidelines

  • The change includes or references documentation updates if necessary

  • Backport labels are set (if applicable)

  • Reviewer has checked that all the criteria below are met

  • Title is accurate

  • All changes are related to the pull request's stated goal

  • Avoids breaking API changes

  • Testing strategy adequately addresses listed risks

  • Newly-added code is easy to change

  • Release note makes sense to a user of the library

  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment

  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy

(cherry picked from commit f64bd48)

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit f64bd48)
@erikayasuda erikayasuda requested review from a team as code owners August 5, 2024 19:59
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 5, 2024
@erikayasuda erikayasuda changed the title chore: add docs/ to apm-python code ownership chore: add docs/ to apm-python code ownership [backport 2.10] Aug 5, 2024
@erikayasuda erikayasuda enabled auto-merge (squash) August 5, 2024 20:00
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-10041-to-2.10
Commit report: 207b021
Test service: dd-trace-py

✅ 0 Failed, 164342 Passed, 12332 Skipped, 10h 39m 30.69s Total duration (56m 58.98s time saved)
⌛ 3 Performance Regressions

⌛ Performance Regressions vs Default Branch (3)

  • test_user_specified_service_integration_v1 - test_pymysql.py 3.31s (+2.69s, +431%) - Details
  • test_schematized_unspecified_service_name_v0 - test_mako.py 3.05s (+2.45s, +406%) - Details
  • test_collect_span_id - test_stack.py 6.76s (+5.75s, +572%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Aug 5, 2024

Benchmarks

Benchmark execution time: 2024-08-05 21:03:58

Comparing candidate commit 207b021 in PR branch backport-10041-to-2.10 with baseline commit a554900 in branch 2.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@erikayasuda erikayasuda merged commit 93089e0 into 2.10 Aug 6, 2024
50 checks passed
@erikayasuda erikayasuda deleted the backport-10041-to-2.10 branch August 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants