Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SSI): set the right permissions (backport #10141 to 2.9) #10144

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Aug 8, 2024

Backport: #10141

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@mabdinur mabdinur requested review from a team as code owners August 8, 2024 17:43
@mabdinur mabdinur changed the title fix(SSI): set the right permissions (#10141) fix(SSI): set the right permissions (backport #10141 to 2.9) Aug 8, 2024
@mabdinur mabdinur requested a review from brettlangdon August 8, 2024 17:46
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-10141-to-2.9
Commit report: d0d5455
Test service: dd-trace-py

✅ 0 Failed, 117342 Passed, 58562 Skipped, 4h 5m 33.25s Total duration (6h 8m 6.54s time saved)

@brettlangdon brettlangdon enabled auto-merge (squash) August 8, 2024 18:02
@brettlangdon brettlangdon merged commit 0e77214 into 2.9 Aug 8, 2024
145 of 149 checks passed
@brettlangdon brettlangdon deleted the backport-10141-to-2.9 branch August 8, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants