-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(django): recreate response stream to prevent reading from empty response body [backport 2.10] #10208
Conversation
…esponse body (#10137) Fixes customer escalation. Customer was using the [Spyne library](https://github.com/arskom/spyne) with Django and making SOAP requests towards it. The problem was found to be that Django integration was reading the response body to set some span tags. However, later in the callstack, Spyne also tries to read the response body (now empty since the stream was fully read). This PR copies/recreates the response body to prevent this error. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 20b8c2b)
Datadog ReportBranch report: ✅ 0 Failed, 175966 Passed, 1571 Skipped, 12h 49m 49.17s Total duration (44m 44.8s time saved) ⌛ Performance Regressions vs Default Branch (17)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #10208 +/- ##
==========================================
- Coverage 11.95% 10.18% -1.78%
==========================================
Files 1309 1313 +4
Lines 124979 125071 +92
==========================================
- Hits 14943 12736 -2207
- Misses 110036 112335 +2299 ☔ View full report in Codecov by Sentry. |
Fixes customer escalation. Customer was using the Spyne library with Django and making SOAP requests towards it. The problem was found to be that Django integration was reading the response body to set some span tags. However, later in the callstack, Spyne also tries to read the response body (now empty since the stream was fully read). This PR copies/recreates the response body to prevent this error.
(cherry picked from commit 20b8c2b)
Checklist
Reviewer Checklist