-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(internal): revert rust rate limiter [backport 2.10] #10229
Conversation
Rust, just revert back to the original pure python rate limiter. The impact here is fairly low, the Rust rate limiter is much faster, but this code isn't the slow part of a hot path, better to be safe than fast. Fixes #10002 - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 5e8c0c0)
Datadog ReportBranch report: ✅ 0 Failed, 143690 Passed, 32780 Skipped, 9h 58m 28.8s Total duration (1h 42m 29.52s time saved) ⌛ Performance Regressions vs Default Branch (5)
|
BenchmarksBenchmark execution time: 2024-08-14 19:52:23 Comparing candidate commit 13f8719 in PR branch Found 1 performance improvements and 5 performance regressions! Performance is the same for 215 metrics, 9 unstable metrics. scenario:otelspan-start
scenario:ratelimiter-defaults
scenario:ratelimiter-high_rate_limit
scenario:ratelimiter-long_window
scenario:ratelimiter-low_rate_limit
scenario:ratelimiter-short_window
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #10229 +/- ##
===========================================
- Coverage 74.24% 10.21% -64.04%
===========================================
Files 1332 1313 -19
Lines 126730 125126 -1604
===========================================
- Hits 94096 12777 -81319
- Misses 32634 112349 +79715 ☔ View full report in Codecov by Sentry. |
Rust, just revert back to the original pure python rate limiter.
The impact here is fairly low, the Rust rate limiter is much faster, but this code isn't the slow part of a hot path, better to be safe than fast.
Fixes #10002
PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)
Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance
policy