-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(asm): improve dependency for api security #11987
chore(asm): improve dependency for api security #11987
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 309 Passed, 1289 Skipped, 5m 47.73s Total duration (33m 54.34s time saved) |
BenchmarksBenchmark execution time: 2025-01-20 11:19:45 Comparing candidate commit 2c856ec in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics. scenario:iast_aspects-format_map_aspect
|
…thub.com/DataDog/dd-trace-py into christophe-papazian/api_security_loading
…pi_security_loading
LGTM! |
In a rare occurence on system tests, api security could create an import error due to circular dependency.
This PR fixes that by delaying ddwaf import at object creation.
It looks like ddwaf import using ctypes may trigger some interaction with gevent. By delaying the import, we prevent possible import errors and appsec disable at start.
APPSEC-56449
Checklist
Reviewer Checklist