-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.4 to CircleCI #4111
Closed
sarahchen6
wants to merge
15
commits into
sarahchen6/update-gemfile-for-3.4
from
sarahchen6/update-circleci-for-3.4
Closed
Add Ruby 3.4 to CircleCI #4111
sarahchen6
wants to merge
15
commits into
sarahchen6/update-gemfile-for-3.4
from
sarahchen6/update-circleci-for-3.4
+3,793
−2,535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to version 2.7.0
fix: Apply DD_VERSION on all spans that use the default or global service name
Adjust OTel Spec for new Ruby 3.4 syntax
Co-authored-by: Oleg Pudeyev <[email protected]>
BenchmarksBenchmark execution time: 2024-11-13 23:20:12 Comparing candidate commit 72773eb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
sarahchen6
force-pushed
the
sarahchen6/update-circleci-for-3.4
branch
from
November 13, 2024 20:41
2f42b5f
to
d182fbd
Compare
sarahchen6
force-pushed
the
sarahchen6/update-circleci-for-3.4
branch
4 times, most recently
from
November 13, 2024 22:28
3c55daf
to
fc7f47d
Compare
sarahchen6
force-pushed
the
sarahchen6/update-circleci-for-3.4
branch
from
November 13, 2024 22:31
fc7f47d
to
ca5820f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds Ruby 3.4 to CircleCI, specifically in the
.circleci/config.yml
file.Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add support for Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.
Change log entry
Ruby 3.4.0-preview2 is now supported.
Additional Notes:
This PR acts alongside #4038 and #4039 .
How to test the change?
Green CI.