Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4 to CircleCI #4111

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Nov 13, 2024

What does this PR do?
This PR adds Ruby 3.4 to CircleCI, specifically in the .circleci/config.yml file.

Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add support for Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.

Change log entry
Ruby 3.4.0-preview2 is now supported.

Additional Notes:
This PR acts alongside #4038 and #4039 .

How to test the change?
Green CI.

@github-actions github-actions bot added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Nov 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-13 23:20:12

Comparing candidate commit 72773eb in PR branch sarahchen6/update-circleci-for-3.4 with baseline commit 494abac in branch sarahchen6/update-gemfile-for-3.4.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/update-circleci-for-3.4 branch from 2f42b5f to d182fbd Compare November 13, 2024 20:41
@sarahchen6 sarahchen6 force-pushed the sarahchen6/update-circleci-for-3.4 branch 4 times, most recently from 3c55daf to fc7f47d Compare November 13, 2024 22:28
@sarahchen6 sarahchen6 force-pushed the sarahchen6/update-circleci-for-3.4 branch from fc7f47d to ca5820f Compare November 13, 2024 22:31
@sarahchen6
Copy link
Contributor Author

This PR' changes (along with #4095 ) have been combined in #4114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants