-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish via Trusted Publishing #4315
base: master
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22117 Passed, 1476 Skipped, 5m 0.83s Total Time |
BenchmarksBenchmark execution time: 2025-01-27 19:04:52 Comparing candidate commit 64920b3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
68a23bc
to
c8d46b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4315 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 1368 1368
Lines 82916 82916
Branches 4209 4209
=======================================
+ Hits 81027 81030 +3
+ Misses 1889 1886 -3 ☔ View full report in Codecov by Sentry. |
c8d46b6
to
0916911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just marking as request changes only because I accidentally hit approve 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the diff and have no objections, thtough I'll leave it to someone else to apply the checkmark.
I'm a bit lost on this work -- what's the relationship between this PR and #4322? |
What does this PR do?
Publish to rubygems.org via Trusted Publishing
Ref: https://guides.rubygems.org/trusted-publishing/
Change log entry
None.