Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish via Trusted Publishing #4315

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jan 23, 2025

What does this PR do?

Publish to rubygems.org via Trusted Publishing

Ref: https://guides.rubygems.org/trusted-publishing/

Change log entry
None.

@TonyCTHsu TonyCTHsu added dev/tooling Involves tools (e.g. Rubocop, CodeCov) do-not-merge/WIP Not ready for merge dev/github Github repository maintenance and automation labels Jan 23, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 23, 2025

Datadog Report

Branch report: tonycthsu/trusted-publishing
Commit report: 64920b3
Test service: dd-trace-rb

✅ 0 Failed, 22117 Passed, 1476 Skipped, 5m 0.83s Total Time

.gitlab-ci.yml Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025

Benchmarks

Benchmark execution time: 2025-01-27 19:04:52

Comparing candidate commit 64920b3 in PR branch tonycthsu/trusted-publishing with baseline commit 494e0e1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/trusted-publishing branch from 68a23bc to c8d46b6 Compare January 23, 2025 16:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (494e0e1) to head (64920b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4315   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files        1368     1368           
  Lines       82916    82916           
  Branches     4209     4209           
=======================================
+ Hits        81027    81030    +3     
+ Misses       1889     1886    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/trusted-publishing branch from c8d46b6 to 0916911 Compare January 24, 2025 14:28
@TonyCTHsu TonyCTHsu removed the do-not-merge/WIP Not ready for merge label Jan 24, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 24, 2025 14:48
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 24, 2025 14:48
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just marking as request changes only because I accidentally hit approve 😓

@brettlangdon brettlangdon dismissed their stale review January 24, 2025 17:07

Not actually blocking anything.

Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the diff and have no objections, thtough I'll leave it to someone else to apply the checkmark.

.github/workflows/publish.yml Show resolved Hide resolved
@ivoanjo
Copy link
Member

ivoanjo commented Jan 27, 2025

I'm a bit lost on this work -- what's the relationship between this PR and #4322?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants