Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount /usr/lib/sysimage/rpm when using host SBOM feature #1541

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Sep 26, 2024

What this PR does / why we need it:

Mount /usr/lib/sysimage/rpm to properly scan Amazon Linux hosts.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@lebauce lebauce requested a review from a team as a code owner September 26, 2024 13:51
@lebauce lebauce force-pushed the lebauce/sysimage-rpm branch from d7061bc to 56db527 Compare September 26, 2024 13:53
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Sep 26, 2024
@lebauce lebauce force-pushed the lebauce/sysimage-rpm branch from 56db527 to b71d5bf Compare September 26, 2024 13:56
@lebauce lebauce added the bug Something isn't working label Oct 2, 2024
@lebauce lebauce force-pushed the lebauce/sysimage-rpm branch from b71d5bf to 63f9175 Compare October 10, 2024 08:02
charts/datadog/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Timothée Bavelier <[email protected]>
@lebauce lebauce requested a review from tbavelier October 14, 2024 12:33
@lebauce
Copy link
Contributor Author

lebauce commented Oct 14, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 14, 2024

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #devflow with those details!

@tbavelier
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 14, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 38m.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Oct 14, 2024

🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • repository configuration requires approval by code owners, but no code owner approved this PR
  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/helm-charts/pulls/1541/merge: 405 Required status check "pr-validated" is expected. []

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-7c6c8c5b7d-vgp4t@): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/1541/merge: 405 Required status check "pr-validated" is expected. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@tbavelier tbavelier enabled auto-merge (squash) October 14, 2024 14:26
@tbavelier tbavelier disabled auto-merge October 14, 2024 14:26
@tbavelier tbavelier merged commit d0bb674 into main Oct 14, 2024
20 checks passed
@tbavelier tbavelier deleted the lebauce/sysimage-rpm branch October 14, 2024 15:08
tbavelier added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants