Add helm option to enable kubernetesUseEndpointSlices and add endpointslices to DCA RBAC #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chart/datadog
Comment on lines
32
to
41
| {{- if .Values.datadog.kubernetesUseEndpointSlices }} | ||
| - apiGroups: | ||
| - "discovery.k8s.io" | ||
| resources: | ||
| - endpointslices | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| {{- end }} |
There was a problem hiding this comment.
IMO it can be part of the default RBAC, because we already have it for service and endpoints
clamoriniere
approved these changes
Dec 19, 2024
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
ewoodthomas/CONTINT-4526_expose_kubernetes_use_endpoint_slices
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DataDog/datadog-agent#32104 allows the DCA to map pods to services through Kubernetes endpointSlice resources instead of endpoints. This PR exposes the config option
datadog.kubernetesUseEndpointSlicesto enable this feature.Also adds
endpointslices.discovery.k8s.ioto the DCA RBAC withget,list, andwatchpermissions. Only added whendatadog.kubernetesUseEndpointSlicesis enabled.Which issue this PR fixes:
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)