Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host cgroup mount to system-probe #1665

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

vitkyrka
Copy link
Contributor

@vitkyrka vitkyrka commented Jan 9, 2025

What this PR does / why we need it:

In the datadog-operator, the host cgroups are mounted in the system-probe container for USM, NPM and (with an ongoing fix DataDog/datadog-operator#1610) Service Discovery, but this is not done in the helm chart.

It is needed get container information for Service Discovery with agent 7.61.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated

In the datadog-operator, the host cgroups are mounted in the
system-probe container for USM, NPM and (with an ongoing fix) Service
Discovery, but this is not done in the helm chart.

It is needed get container information for Service Discovery with agent
7.61.
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Jan 9, 2025
@vitkyrka vitkyrka marked this pull request as ready for review January 9, 2025 12:10
@vitkyrka vitkyrka requested review from a team as code owners January 9, 2025 12:10
@tbavelier
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-10 08:33:52 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 38m.


2025-01-10 08:34:17 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@tbavelier
Copy link
Member

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-10 08:34:14 UTC ℹ️ Devflow: /remove

@tbavelier
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-10 08:40:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-10 09:25:17 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 38m.


2025-01-10 10:02:09 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants