-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resilience4j): add new integration #2581
base: master
Are you sure you want to change the base?
Conversation
9edf23a
to
6524032
Compare
Thank you! I've added an editorial review card for our team to review further. |
Co-authored-by: Ursula Chen <[email protected]>
c042a72
to
1c87943
Compare
1c87943
to
40c5543
Compare
Hi @urseberry , Here's the error message from the pipeline: Generated XML file: /home/runner/work/integrations-extras/integrations-extras/resilience4j/.junit/test-e2e-py3.11.xml
============================ 1 deselected in 0.02s ============================
──────────── Stopping: resilience4j:py3.11 ────────────
Container docker-tester-1 Stopping
Container docker-tester-1 Stopped
Container docker-tester-1 Removing
Container docker-tester-1 Removed
Container resilience4j Stopping
Container resilience4j Stopped
Container resilience4j Removing
Container resilience4j Removed
Network docker_default Removing
Network docker_default Removed
Error: Process completed with exit code 5. Thank you for your assistance! |
@willianccs Sorry, I'm not able to help. I'm a technical writer, so I'll review the parts of this pull request that impact public documentation, but I don't know how the pipeline or unit tests work. An engineer should review soon, and they will be able to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more wording recommendations.
resilience4j/assets/monitors/circuitbreaker_state_open_slow_calls.json
Outdated
Show resolved
Hide resolved
resilience4j/assets/monitors/circuitbreaker_state_open_slow_calls.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
…lls.json Co-authored-by: Ursula Chen <[email protected]>
…lls.json Co-authored-by: Ursula Chen <[email protected]>
Thank you for your review and the response! |
What does this PR do?
Create a new integration for
Resilience4j
.Motivation
What inspired you to submit this pull request?
Currently we are exporting as custom metrics and would be very helpful to be send as integration.
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?