Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resilience4j): add new integration #2581

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

willianccs
Copy link

What does this PR do?

Create a new integration for Resilience4j.

Resilience4j is a lightweight fault tolerance library designed for functional programming. Resilience4j provides higher-order functions (decorators) to enhance any functional interface, lambda expression or method reference with a Circuit Breaker, Rate Limiter, Retry or Bulkhead.

Motivation

What inspired you to submit this pull request?

Currently we are exporting as custom metrics and would be very helpful to be send as integration.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@willianccs willianccs requested review from a team as code owners January 16, 2025 15:05
@aliciascott aliciascott added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 16, 2025
@aliciascott
Copy link
Contributor

Thank you! I've added an editorial review card for our team to review further.

resilience4j/assets/dashboards/resilience4j_overview.json Outdated Show resolved Hide resolved
resilience4j/manifest.json Outdated Show resolved Hide resolved
resilience4j/images/IMAGES_README.md Outdated Show resolved Hide resolved
resilience4j/README.md Outdated Show resolved Hide resolved
resilience4j/README.md Outdated Show resolved Hide resolved
@willianccs willianccs requested a review from a team as a code owner January 24, 2025 22:06
@willianccs willianccs force-pushed the feat/resilience4j branch 7 times, most recently from c042a72 to 1c87943 Compare January 26, 2025 15:21
@willianccs
Copy link
Author

Hi @urseberry ,
I've made some fixes, but I'm currently encountering an error during the unit tests. Could you help me resolve it?

Here's the error message from the pipeline:

Generated XML file: /home/runner/work/integrations-extras/integrations-extras/resilience4j/.junit/test-e2e-py3.11.xml

============================ 1 deselected in 0.02s ============================

──────────── Stopping: resilience4j:py3.11 ────────────
 Container docker-tester-1  Stopping
 Container docker-tester-1  Stopped
 Container docker-tester-1  Removing
 Container docker-tester-1  Removed
 Container resilience4j  Stopping
 Container resilience4j  Stopped
 Container resilience4j  Removing
 Container resilience4j  Removed
 Network docker_default  Removing
 Network docker_default  Removed

Error: Process completed with exit code 5.

Thank you for your assistance!

@urseberry
Copy link
Contributor

Hi @urseberry , I've made some fixes, but I'm currently encountering an error during the unit tests. Could you help me resolve it?

Here's the error message from the pipeline:

Generated XML file: /home/runner/work/integrations-extras/integrations-extras/resilience4j/.junit/test-e2e-py3.11.xml

============================ 1 deselected in 0.02s ============================

──────────── Stopping: resilience4j:py3.11 ────────────
 Container docker-tester-1  Stopping
 Container docker-tester-1  Stopped
 Container docker-tester-1  Removing
 Container docker-tester-1  Removed
 Container resilience4j  Stopping
 Container resilience4j  Stopped
 Container resilience4j  Removing
 Container resilience4j  Removed
 Network docker_default  Removing
 Network docker_default  Removed

Error: Process completed with exit code 5.

Thank you for your assistance!

@willianccs Sorry, I'm not able to help. I'm a technical writer, so I'll review the parts of this pull request that impact public documentation, but I don't know how the pipeline or unit tests work. An engineer should review soon, and they will be able to help.

Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more wording recommendations.

@willianccs
Copy link
Author

@willianccs Sorry, I'm not able to help. I'm a technical writer, so I'll review the parts of this pull request that impact public documentation, but I don't know how the pipeline or unit tests work. An engineer should review soon, and they will be able to help.

Thank you for your review and the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review from a docs team editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants