Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typingdna ActiveLock - new dashboard, version 3.0 (ECOINT-86) #2585

Merged
merged 13 commits into from
Feb 11, 2025

Conversation

raulpopa
Copy link
Contributor

@raulpopa raulpopa commented Jan 21, 2025

What does this PR do?

New update for the main dashboard as we added a new main action: lock.

Motivation

New update for the main dashboard as we added a new main action: lock.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

Sorry, something went wrong.

New dashboard update. Only the dashboard is different, no other change.
Update the dashboard jpg for manifest, and changelog.md update to support the new dashboard update.
Date format fixed
Fixed changelog type
@raulpopa raulpopa requested review from a team as code owners January 21, 2025 01:13
@raulpopa raulpopa requested a review from bgoldberg122 January 21, 2025 01:13
@raulpopa
Copy link
Contributor Author

Just a minor update for the main dashboard as we added a new main action: lock.

raulpopa and others added 4 commits January 23, 2025 15:24
Requested updates for dashboard look and json format.
added details..
@raulpopa raulpopa requested a review from dd-dominic January 23, 2025 20:52
@dd-dominic
Copy link
Collaborator

@raulpopa one more item - please update the manifest file to include "Submitted Data Type::Logs". This is presented in the tile and helps users understand what type of data is submitted.

See example here: https://github.com/DataDog/integrations-extras/blob/master/modal/manifest.json#L34

@raulpopa
Copy link
Contributor Author

@dd-dominic is there anything else you need from me?

@dd-dominic dd-dominic changed the title Typingdna ActiveLock - new dashboard, version 3.0 Typingdna ActiveLock - new dashboard, version 3.0 (ECOINT-86) Jan 29, 2025
Copy link
Collaborator

@dd-dominic dd-dominic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized changelog is in reverse order

typingdna_activelock/CHANGELOG.md Outdated Show resolved Hide resolved
@raulpopa raulpopa requested a review from dd-dominic January 30, 2025 22:43
@raulpopa
Copy link
Contributor Author

raulpopa commented Feb 4, 2025

@dd-dominic Why is this taking so long? I want to be able to share this with a client who wants to use this new dashboard, and it takes a week for any minor review. I did all the requested changes right away, then after each I have to wait for days.. can you please do a final review and finalize the PR. Please..

Copy link
Collaborator

@dd-dominic dd-dominic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raulpopa looks good now. Appreciate your patience while we work through a backlog of requests.

@bgoldberg122 bgoldberg122 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into DataDog:master with commit 2f17e22 Feb 11, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants